Revision 23918b03060f6e572168fdde1798a905679d2e06 authored by Trond Myklebust on 20 November 2008, 21:06:21 UTC, committed by Linus Torvalds on 20 November 2008, 21:17:40 UTC
Fix a regression reported by Max Kellermann whereby kernel profiling
showed that his clients were spending 45% of their time in
rpcauth_lookup_credcache.

It turns out that although his processes had identical uid/gid/groups,
generic_match() was failing to detect this, because the task->group_info
pointers were not shared. This again lead to the creation of a huge number
of identical credentials at the RPC layer.

The regression is fixed by comparing the contents of task->group_info
if the actual pointers are not identical.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0cb39aa
History
File Mode Size
Kconfig -rw-r--r-- 2.9 KB
Kconfig.iosched -rw-r--r-- 1.9 KB
Makefile -rw-r--r-- 627 bytes
as-iosched.c -rw-r--r-- 38.7 KB
blk-barrier.c -rw-r--r-- 9.0 KB
blk-core.c -rw-r--r-- 57.2 KB
blk-exec.c -rw-r--r-- 2.7 KB
blk-integrity.c -rw-r--r-- 9.8 KB
blk-ioc.c -rw-r--r-- 4.0 KB
blk-map.c -rw-r--r-- 8.0 KB
blk-merge.c -rw-r--r-- 9.9 KB
blk-settings.c -rw-r--r-- 14.5 KB
blk-softirq.c -rw-r--r-- 4.1 KB
blk-sysfs.c -rw-r--r-- 9.2 KB
blk-tag.c -rw-r--r-- 9.8 KB
blk-timeout.c -rw-r--r-- 5.3 KB
blk.h -rw-r--r-- 3.1 KB
blktrace.c -rw-r--r-- 12.3 KB
bsg.c -rw-r--r-- 23.1 KB
cfq-iosched.c -rw-r--r-- 57.2 KB
cmd-filter.c -rw-r--r-- 5.4 KB
compat_ioctl.c -rw-r--r-- 20.9 KB
deadline-iosched.c -rw-r--r-- 11.4 KB
elevator.c -rw-r--r-- 26.8 KB
genhd.c -rw-r--r-- 27.2 KB
ioctl.c -rw-r--r-- 8.7 KB
noop-iosched.c -rw-r--r-- 2.6 KB
scsi_ioctl.c -rw-r--r-- 17.1 KB

back to top