Revision 2413a06c7bf2a1f3e86680ceb041e75c729f44f1 authored by Igor Canadi on 24 April 2014, 13:22:58 UTC, committed by Igor Canadi on 24 April 2014, 13:22:58 UTC
Summary:
Currently, whenever DB Verification fails we bail out by calling `exit(1)`. This is kind of bad since it causes unclean shutdown and spew of error log messages like:
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
This diff adds a new parameter that is set to true when verification fails. It can then use the parameter to bail out safely.
Test Plan: Casued artificail failure. Verified that exit was clean.
Reviewers: dhruba, haobo, ljin
Reviewed By: haobo
CC: leveldb
Differential Revision: https://reviews.facebook.net/D18243
1 parent d8fe006
| File | Mode | Size |
|---|---|---|
| win | ||
| README | -rw-r--r-- | 405 bytes |
| atomic_pointer.h | -rw-r--r-- | 4.9 KB |
| likely.h | -rw-r--r-- | 780 bytes |
| port.h | -rw-r--r-- | 917 bytes |
| port_example.h | -rw-r--r-- | 4.5 KB |
| port_posix.cc | -rw-r--r-- | 3.0 KB |
| port_posix.h | -rw-r--r-- | 12.9 KB |
| stack_trace.cc | -rw-r--r-- | 3.0 KB |
| stack_trace.h | -rw-r--r-- | 678 bytes |
Computing file changes ...
