Revision 2413a06c7bf2a1f3e86680ceb041e75c729f44f1 authored by Igor Canadi on 24 April 2014, 13:22:58 UTC, committed by Igor Canadi on 24 April 2014, 13:22:58 UTC
Summary:
Currently, whenever DB Verification fails we bail out by calling `exit(1)`. This is kind of bad since it causes unclean shutdown and spew of error log messages like:
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
This diff adds a new parameter that is set to true when verification fails. It can then use the parameter to bail out safely.
Test Plan: Casued artificail failure. Verified that exit was clean.
Reviewers: dhruba, haobo, ljin
Reviewed By: haobo
CC: leveldb
Differential Revision: https://reviews.facebook.net/D18243
1 parent d8fe006
| File | Mode | Size |
|---|---|---|
| auto_sanity_test.sh | -rwxr-xr-x | 2.1 KB |
| blob_store_bench.cc | -rw-r--r-- | 7.5 KB |
| db_crashtest.py | -rw-r--r-- | 4.8 KB |
| db_crashtest2.py | -rw-r--r-- | 5.7 KB |
| db_repl_stress.cc | -rw-r--r-- | 4.0 KB |
| db_sanity_test.cc | -rw-r--r-- | 5.5 KB |
| db_stress.cc | -rw-r--r-- | 58.1 KB |
| ldb.cc | -rw-r--r-- | 424 bytes |
| ldb_test.py | -rw-r--r-- | 17.0 KB |
| reduce_levels_test.cc | -rw-r--r-- | 4.9 KB |
| sst_dump.cc | -rw-r--r-- | 10.8 KB |
Computing file changes ...
