https://github.com/torvalds/linux
Revision 29acfb65598f91671413869e0d0a1ec4e74ac705 authored by Frank Rowand on 16 April 2020, 21:42:50 UTC, committed by Rob Herring on 17 April 2020, 13:31:34 UTC
kmemleak reports several memory leaks from devicetree unittest. This is the fix for problem 5 of 5. When overlay 'overlay_bad_add_dup_prop' is applied, the apply code properly detects that a memory leak will occur if the overlay is removed since the duplicate property is located in a base devicetree node and reports via printk(): OF: overlay: WARNING: memory leak will occur if overlay removed, property: /testcase-data-2/substation@100/motor-1/rpm_avail OF: overlay: WARNING: memory leak will occur if overlay removed, property: /testcase-data-2/substation@100/motor-1/rpm_avail The overlay is removed when the apply code detects multiple changesets modifying the same property. This is reported via printk(): OF: overlay: ERROR: multiple fragments add, update, and/or delete property /testcase-data-2/substation@100/motor-1/rpm_avail As a result of this error, the overlay is removed resulting in the expected memory leak. Add another device node level to the overlay so that the duplicate property is located in a node added by the overlay, thus no memory leak will occur when the overlay is removed. Thus users of kmemleak will not have to debug this leak in the future. Fixes: 2fe0e8769df9 ("of: overlay: check prevents multiple fragments touching same property") Reported-by: Erhard F. <erhard_f@mailbox.org> Signed-off-by: Frank Rowand <frank.rowand@sony.com> Signed-off-by: Rob Herring <robh@kernel.org>
1 parent 478ff64
Tip revision: 29acfb65598f91671413869e0d0a1ec4e74ac705 authored by Frank Rowand on 16 April 2020, 21:42:50 UTC
of: unittest: kmemleak in duplicate property update
of: unittest: kmemleak in duplicate property update
Tip revision: 29acfb6
Computing file changes ...