Revision 2df8f8a6a897ebf4c5613b5be6103d33b2a21520 authored by Steven Rostedt on 11 January 2013, 21:14:10 UTC, committed by Steven Rostedt on 11 January 2013, 21:14:10 UTC
Commit 02404baf1b47 "tracing: Remove deprecated tracing_enabled file" removed the tracing_enabled file as it never worked properly and the tracing_on file should be used instead. But the tracing_on file didn't call into the tracers start/stop routines like the tracing_enabled file did. This caused trace-cmd to break when it enabled the irqsoff tracer. If you just did "echo irqsoff > current_tracer" then it would work properly. But the tool trace-cmd disables tracing first by writing "0" into the tracing_on file. Then it writes "irqsoff" into current_tracer and then writes "1" into tracing_on. Unfortunately, the above commit changed the irqsoff tracer to check the tracing_on status instead of the tracing_enabled status. If it's disabled then it does not start the tracer internals. The problem is that writing "1" into tracing_on does not call the tracers "start" routine like writing "1" into tracing_enabled did. This makes the irqsoff tracer not start when using the trace-cmd tool, and is a regression for userspace. Simple fix is to have the tracing_on file call the tracers start() method when being enabled (and the stop() method when disabled). Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
1 parent a8dd217
File | Mode | Size |
---|---|---|
debug | ||
events | ||
gcov | ||
irq | ||
power | ||
sched | ||
time | ||
trace | ||
.gitignore | -rw-r--r-- | 63 bytes |
Kconfig.freezer | -rw-r--r-- | 52 bytes |
Kconfig.hz | -rw-r--r-- | 1.7 KB |
Kconfig.locks | -rw-r--r-- | 4.3 KB |
Kconfig.preempt | -rw-r--r-- | 2.1 KB |
Makefile | -rw-r--r-- | 7.2 KB |
acct.c | -rw-r--r-- | 16.6 KB |
async.c | -rw-r--r-- | 10.4 KB |
audit.c | -rw-r--r-- | 40.5 KB |
audit.h | -rw-r--r-- | 5.8 KB |
audit_tree.c | -rw-r--r-- | 22.1 KB |
audit_watch.c | -rw-r--r-- | 13.9 KB |
auditfilter.c | -rw-r--r-- | 36.1 KB |
auditsc.c | -rw-r--r-- | 71.8 KB |
backtracetest.c | -rw-r--r-- | 2.1 KB |
bounds.c | -rw-r--r-- | 600 bytes |
capability.c | -rw-r--r-- | 11.7 KB |
cgroup.c | -rw-r--r-- | 147.5 KB |
cgroup_freezer.c | -rw-r--r-- | 12.9 KB |
compat.c | -rw-r--r-- | 30.7 KB |
configs.c | -rw-r--r-- | 2.8 KB |
context_tracking.c | -rw-r--r-- | 2.1 KB |
cpu.c | -rw-r--r-- | 17.4 KB |
cpu_pm.c | -rw-r--r-- | 6.5 KB |
cpuset.c | -rw-r--r-- | 73.8 KB |
crash_dump.c | -rw-r--r-- | 1.2 KB |
cred.c | -rw-r--r-- | 21.2 KB |
delayacct.c | -rw-r--r-- | 5.0 KB |
dma.c | -rw-r--r-- | 3.6 KB |
elfcore.c | -rw-r--r-- | 459 bytes |
exec_domain.c | -rw-r--r-- | 4.3 KB |
exit.c | -rw-r--r-- | 42.9 KB |
extable.c | -rw-r--r-- | 3.9 KB |
fork.c | -rw-r--r-- | 45.4 KB |
freezer.c | -rw-r--r-- | 4.0 KB |
futex.c | -rw-r--r-- | 71.2 KB |
futex_compat.c | -rw-r--r-- | 4.5 KB |
groups.c | -rw-r--r-- | 6.0 KB |
hrtimer.c | -rw-r--r-- | 47.0 KB |
hung_task.c | -rw-r--r-- | 5.3 KB |
irq_work.c | -rw-r--r-- | 3.1 KB |
itimer.c | -rw-r--r-- | 7.3 KB |
jump_label.c | -rw-r--r-- | 10.8 KB |
kallsyms.c | -rw-r--r-- | 14.7 KB |
kcmp.c | -rw-r--r-- | 4.3 KB |
kexec.c | -rw-r--r-- | 39.6 KB |
kfifo.c | -rw-r--r-- | 12.8 KB |
kmod.c | -rw-r--r-- | 18.9 KB |
kprobes.c | -rw-r--r-- | 59.1 KB |
ksysfs.c | -rw-r--r-- | 5.5 KB |
kthread.c | -rw-r--r-- | 16.9 KB |
latencytop.c | -rw-r--r-- | 7.6 KB |
lglock.c | -rw-r--r-- | 1.9 KB |
lockdep.c | -rw-r--r-- | 103.8 KB |
lockdep_internals.h | -rw-r--r-- | 4.5 KB |
lockdep_proc.c | -rw-r--r-- | 17.0 KB |
lockdep_states.h | -rw-r--r-- | 233 bytes |
modsign_certificate.S | -rw-r--r-- | 467 bytes |
modsign_pubkey.c | -rw-r--r-- | 2.6 KB |
module-internal.h | -rw-r--r-- | 495 bytes |
module.c | -rw-r--r-- | 93.5 KB |
module_signing.c | -rw-r--r-- | 5.9 KB |
mutex-debug.c | -rw-r--r-- | 2.9 KB |
mutex-debug.h | -rw-r--r-- | 1.7 KB |
mutex.c | -rw-r--r-- | 13.2 KB |
mutex.h | -rw-r--r-- | 1.3 KB |
notifier.c | -rw-r--r-- | 16.0 KB |
nsproxy.c | -rw-r--r-- | 6.3 KB |
padata.c | -rw-r--r-- | 27.1 KB |
panic.c | -rw-r--r-- | 11.2 KB |
params.c | -rw-r--r-- | 21.7 KB |
pid.c | -rw-r--r-- | 14.8 KB |
pid_namespace.c | -rw-r--r-- | 8.8 KB |
posix-cpu-timers.c | -rw-r--r-- | 40.7 KB |
posix-timers.c | -rw-r--r-- | 29.1 KB |
printk.c | -rw-r--r-- | 70.1 KB |
profile.c | -rw-r--r-- | 16.7 KB |
ptrace.c | -rw-r--r-- | 26.6 KB |
range.c | -rw-r--r-- | 2.9 KB |
rcu.h | -rw-r--r-- | 3.8 KB |
rcupdate.c | -rw-r--r-- | 11.8 KB |
rcutiny.c | -rw-r--r-- | 10.3 KB |
rcutiny_plugin.h | -rw-r--r-- | 31.6 KB |
rcutorture.c | -rw-r--r-- | 62.2 KB |
rcutree.c | -rw-r--r-- | 94.4 KB |
rcutree.h | -rw-r--r-- | 22.7 KB |
rcutree_plugin.h | -rw-r--r-- | 73.5 KB |
rcutree_trace.c | -rw-r--r-- | 12.9 KB |
relay.c | -rw-r--r-- | 32.8 KB |
res_counter.c | -rw-r--r-- | 4.3 KB |
resource.c | -rw-r--r-- | 27.8 KB |
rtmutex-debug.c | -rw-r--r-- | 4.7 KB |
rtmutex-debug.h | -rw-r--r-- | 1.4 KB |
rtmutex-tester.c | -rw-r--r-- | 8.7 KB |
rtmutex.c | -rw-r--r-- | 26.3 KB |
rtmutex.h | -rw-r--r-- | 1.1 KB |
rtmutex_common.h | -rw-r--r-- | 3.3 KB |
rwsem.c | -rw-r--r-- | 2.3 KB |
seccomp.c | -rw-r--r-- | 13.9 KB |
semaphore.c | -rw-r--r-- | 7.2 KB |
signal.c | -rw-r--r-- | 87.7 KB |
smp.c | -rw-r--r-- | 21.7 KB |
smpboot.c | -rw-r--r-- | 6.5 KB |
smpboot.h | -rw-r--r-- | 564 bytes |
softirq.c | -rw-r--r-- | 20.8 KB |
spinlock.c | -rw-r--r-- | 9.5 KB |
srcu.c | -rw-r--r-- | 19.6 KB |
stacktrace.c | -rw-r--r-- | 1.1 KB |
stop_machine.c | -rw-r--r-- | 15.5 KB |
sys.c | -rw-r--r-- | 52.2 KB |
sys_ni.c | -rw-r--r-- | 5.9 KB |
sysctl.c | -rw-r--r-- | 59.5 KB |
sysctl_binary.c | -rw-r--r-- | 51.5 KB |
task_work.c | -rw-r--r-- | 2.2 KB |
taskstats.c | -rw-r--r-- | 16.4 KB |
test_kprobes.c | -rw-r--r-- | 8.5 KB |
time.c | -rw-r--r-- | 18.6 KB |
timeconst.pl | -rw-r--r-- | 7.2 KB |
timer.c | -rw-r--r-- | 49.6 KB |
tracepoint.c | -rw-r--r-- | 19.7 KB |
tsacct.c | -rw-r--r-- | 4.4 KB |
uid16.c | -rw-r--r-- | 6.0 KB |
up.c | -rw-r--r-- | 413 bytes |
user-return-notifier.c | -rw-r--r-- | 1.3 KB |
user.c | -rw-r--r-- | 5.2 KB |
user_namespace.c | -rw-r--r-- | 21.2 KB |
utsname.c | -rw-r--r-- | 2.8 KB |
utsname_sysctl.c | -rw-r--r-- | 3.0 KB |
wait.c | -rw-r--r-- | 8.3 KB |
watchdog.c | -rw-r--r-- | 13.9 KB |
workqueue.c | -rw-r--r-- | 106.5 KB |
workqueue_sched.h | -rw-r--r-- | 311 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...