Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision 2e3c18d0ada16f145087b2687afcad1748c0827c authored by Tetsuo Handa on 30 January 2019, 13:21:45 UTC, committed by Jens Axboe on 30 January 2019, 15:53:20 UTC 
block: pass no-op callback to INIT_WORK().
 
syzbot is hitting flush_work() warning caused by commit 4d43d395fed12463
("workqueue: Try to catch flush_work() without INIT_WORK().") [1].
Although that commit did not expect INIT_WORK(NULL) case, calling
flush_work() without setting a valid callback should be avoided anyway.
Fix this problem by setting a no-op callback instead of NULL.

[1] https://syzkaller.appspot.com/bug?id=e390366bc48bc82a7c668326e0663be3b91cbd29

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reported-and-tested-by: syzbot <syzbot+ba2a929dcf8e704c180e@syzkaller.appspotmail.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 3ca17a2
History
Tip revision: 2e3c18d0ada16f145087b2687afcad1748c0827c authored by Tetsuo Handa on 30 January 2019, 13:21:45 UTC
block: pass no-op callback to INIT_WORK().
Tip revision: 2e3c18d
File Mode Size
.gitignore -rw-r--r-- 44 bytes
Kconfig -rw-r--r-- 3.4 KB
Makefile -rw-r--r-- 4.1 KB
blacklist.c -rw-r--r-- 4.0 KB
blacklist.h -rw-r--r-- 84 bytes
blacklist_hashes.c -rw-r--r-- 166 bytes
blacklist_nohashes.c -rw-r--r-- 122 bytes
system_certificates.S -rw-r--r-- 828 bytes
system_keyring.c -rw-r--r-- 7.5 KB
back to top