Revision 2fdba6b085eb7068e9594cfa55ffe40466184b4d authored by Herbert Xu on 19 May 2005, 05:52:33 UTC, committed by David S. Miller on 19 May 2005, 05:52:33 UTC
Having frag_list members which holds wmem of an sk leads to nightmares
with partially cloned frag skb's.  The reason is that once you unleash
a skb with a frag_list that has individual sk ownerships into the stack
you can never undo those ownerships safely as they may have been cloned
by things like netfilter.  Since we have to undo them in order to make
skb_linearize happy this approach leads to a dead-end.

So let's go the other way and make this an invariant:

	For any skb on a frag_list, skb->sk must be NULL.

That is, the socket ownership always belongs to the head skb.
It turns out that the implementation is actually pretty simple.

The above invariant is actually violated in the following patch
for a short duration inside ip_fragment.  This is OK because the
offending frag_list member is either destroyed at the end of the
slow path without being sent anywhere, or it is detached from
the frag_list before being sent.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent d481020
History
File Mode Size
adfs
affs
afs
autofs
autofs4
befs
bfs
cifs
coda
cramfs
debugfs
devfs
devpts
efs
exportfs
ext2
ext3
fat
freevxfs
hfs
hfsplus
hostfs
hpfs
hppfs
hugetlbfs
isofs
jbd
jffs
jffs2
jfs
lockd
minix
msdos
ncpfs
nfs
nfsd
nls
ntfs
openpromfs
partitions
proc
qnx4
ramfs
reiserfs
romfs
smbfs
sysfs
sysv
udf
ufs
umsdos
vfat
xfs
Kconfig -rw-r--r-- 63.6 KB
Kconfig.binfmt -rw-r--r-- 5.3 KB
Makefile -rw-r--r-- 3.0 KB
aio.c -rw-r--r-- 43.3 KB
attr.c -rw-r--r-- 5.0 KB
bad_inode.c -rw-r--r-- 2.8 KB
binfmt_aout.c -rw-r--r-- 14.8 KB
binfmt_elf.c -rw-r--r-- 45.2 KB
binfmt_elf_fdpic.c -rw-r--r-- 30.3 KB
binfmt_em86.c -rw-r--r-- 2.8 KB
binfmt_flat.c -rw-r--r-- 25.7 KB
binfmt_misc.c -rw-r--r-- 15.6 KB
binfmt_script.c -rw-r--r-- 2.7 KB
binfmt_som.c -rw-r--r-- 7.7 KB
bio.c -rw-r--r-- 25.4 KB
block_dev.c -rw-r--r-- 21.7 KB
buffer.c -rw-r--r-- 81.9 KB
char_dev.c -rw-r--r-- 9.2 KB
compat.c -rw-r--r-- 47.0 KB
compat_ioctl.c -rw-r--r-- 85.0 KB
dcache.c -rw-r--r-- 43.9 KB
dcookies.c -rw-r--r-- 6.3 KB
direct-io.c -rw-r--r-- 34.5 KB
dnotify.c -rw-r--r-- 4.3 KB
dquot.c -rw-r--r-- 51.6 KB
eventpoll.c -rw-r--r-- 44.0 KB
exec.c -rw-r--r-- 33.7 KB
fcntl.c -rw-r--r-- 13.1 KB
fifo.c -rw-r--r-- 3.2 KB
file.c -rw-r--r-- 5.5 KB
file_table.c -rw-r--r-- 5.9 KB
filesystems.c -rw-r--r-- 5.2 KB
fs-writeback.c -rw-r--r-- 19.7 KB
inode.c -rw-r--r-- 34.3 KB
ioctl.c -rw-r--r-- 3.9 KB
libfs.c -rw-r--r-- 12.9 KB
locks.c -rw-r--r-- 54.3 KB
mbcache.c -rw-r--r-- 18.3 KB
mpage.c -rw-r--r-- 20.6 KB
namei.c -rw-r--r-- 59.4 KB
namespace.c -rw-r--r-- 34.8 KB
nfsctl.c -rw-r--r-- 2.5 KB
open.c -rw-r--r-- 23.1 KB
pipe.c -rw-r--r-- 18.1 KB
posix_acl.c -rw-r--r-- 8.6 KB
quota.c -rw-r--r-- 8.8 KB
quota_v1.c -rw-r--r-- 5.7 KB
quota_v2.c -rw-r--r-- 20.1 KB
read_write.c -rw-r--r-- 15.3 KB
readdir.c -rw-r--r-- 6.7 KB
select.c -rw-r--r-- 12.2 KB
seq_file.c -rw-r--r-- 9.5 KB
stat.c -rw-r--r-- 9.2 KB
super.c -rw-r--r-- 19.9 KB
xattr.c -rw-r--r-- 10.3 KB
xattr_acl.c -rw-r--r-- 2.3 KB

back to top