Revision 32c356d76d7e13dcd0675189d8e9c64ef66aa561 authored by James Bottomley on 19 August 2008, 22:58:13 UTC, committed by James Bottomley on 23 October 2008, 16:41:16 UTC
On Tue, 12 Aug 2008 15:08:14 +0200 Giuliano Pochini <pochini@shiny.it> wrote: > Fujitsu magneto-optical drive, Adaptec 29160 and > Linux Jay 2.6.26 #7 SMP Sun Aug 10 18:34:22 CEST 2008 ppc 7455, altivec supported PowerMac3,6 GNU/Linux > > When I insert a disk and I mount it, scsi_test_unit_ready() is called and > the do-while loop gets sshdr->sense_key == UNIT_ATTENTION in the first > cycle and 0 in the second one. So the if below misses the UNIT_ATTENTION > and sdev->changed = 1 is not executed. At this point bad things can > happen... I'm not sure how to fix this. Any clue ? The problem is essentially caused by us eating UNIT_ATTENTION conditions in scsi_test_unit_ready(). Fix by updating the ->changed flag when this happens if the media is removable. [pochini@shiny.it: updates to tidy up patch] Signed-off-by: Giuliano Pochini <pochini@shiny.it> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
1 parent 26e9a39
File | Mode | Size |
---|---|---|
Makefile | -rw-r--r-- | 335 bytes |
compat.c | -rw-r--r-- | 17.0 KB |
compat_mq.c | -rw-r--r-- | 4.0 KB |
ipc_sysctl.c | -rw-r--r-- | 6.9 KB |
ipcns_notifier.c | -rw-r--r-- | 2.2 KB |
mqueue.c | -rw-r--r-- | 30.0 KB |
msg.c | -rw-r--r-- | 20.8 KB |
msgutil.c | -rw-r--r-- | 2.3 KB |
namespace.c | -rw-r--r-- | 2.5 KB |
sem.c | -rw-r--r-- | 33.8 KB |
shm.c | -rw-r--r-- | 25.1 KB |
util.c | -rw-r--r-- | 23.0 KB |
util.h | -rw-r--r-- | 4.5 KB |
Computing file changes ...