https://github.com/torvalds/linux
Revision 363e59baa4f76d3f97c0133ff7014cba3d90a7c3 authored by Darrick J. Wong on 14 December 2017, 23:42:59 UTC, committed by Darrick J. Wong on 21 December 2017, 16:47:28 UTC
Currently, xfs_itruncate_extents clears the cowblocks tag if i_cnextents
is zero.  This is wrong, since i_cnextents only tracks real extents in
the CoW fork, which means that we could have some delayed CoW
reservations still in there that will now never get cleaned.

Fix a further bug where we /don't/ clear the reflink iflag if there are
any attribute blocks -- really, it's only safe to clear the reflink flag
if there are no data fork extents and no cow fork extents.

Found by adding clonerange to fsstress in xfs/017.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
1 parent 91aae6b
History
Tip revision: 363e59baa4f76d3f97c0133ff7014cba3d90a7c3 authored by Darrick J. Wong on 14 December 2017, 23:42:59 UTC
xfs: don't be so eager to clear the cowblocks tag on truncate
Tip revision: 363e59b
File Mode Size
9p
adfs
affs
afs
autofs4
befs
bfs
btrfs
cachefiles
ceph
cifs
coda
configfs
cramfs
crypto
debugfs
devpts
dlm
ecryptfs
efivarfs
efs
exofs
exportfs
ext2
ext4
f2fs
fat
freevxfs
fscache
fuse
gfs2
hfs
hfsplus
hostfs
hpfs
hugetlbfs
isofs
jbd2
jffs2
jfs
kernfs
lockd
minix
ncpfs
nfs
nfs_common
nfsd
nilfs2
nls
notify
ntfs
ocfs2
omfs
openpromfs
orangefs
overlayfs
proc
pstore
qnx4
qnx6
quota
ramfs
reiserfs
romfs
squashfs
sysfs
sysv
tracefs
ubifs
udf
ufs
xfs
Kconfig -rw-r--r-- 7.1 KB
Kconfig.binfmt -rw-r--r-- 7.2 KB
Makefile -rw-r--r-- 4.3 KB
aio.c -rw-r--r-- 46.5 KB
anon_inodes.c -rw-r--r-- 4.9 KB
attr.c -rw-r--r-- 9.2 KB
bad_inode.c -rw-r--r-- 5.3 KB
binfmt_aout.c -rw-r--r-- 10.8 KB
binfmt_elf.c -rw-r--r-- 63.1 KB
binfmt_elf_fdpic.c -rw-r--r-- 47.3 KB
binfmt_em86.c -rw-r--r-- 2.8 KB
binfmt_flat.c -rw-r--r-- 27.7 KB
binfmt_misc.c -rw-r--r-- 18.2 KB
binfmt_script.c -rw-r--r-- 3.0 KB
block_dev.c -rw-r--r-- 53.1 KB
buffer.c -rw-r--r-- 93.1 KB
char_dev.c -rw-r--r-- 16.7 KB
compat.c -rw-r--r-- 5.1 KB
compat_binfmt_elf.c -rw-r--r-- 3.4 KB
compat_ioctl.c -rw-r--r-- 42.7 KB
coredump.c -rw-r--r-- 21.2 KB
dax.c -rw-r--r-- 43.9 KB
dcache.c -rw-r--r-- 94.5 KB
dcookies.c -rw-r--r-- 6.9 KB
direct-io.c -rw-r--r-- 40.4 KB
drop_caches.c -rw-r--r-- 1.6 KB
eventfd.c -rw-r--r-- 12.9 KB
eventpoll.c -rw-r--r-- 62.9 KB
exec.c -rw-r--r-- 45.8 KB
fcntl.c -rw-r--r-- 23.0 KB
fhandle.c -rw-r--r-- 6.8 KB
file.c -rw-r--r-- 23.3 KB
file_table.c -rw-r--r-- 8.6 KB
filesystems.c -rw-r--r-- 6.5 KB
fs-writeback.c -rw-r--r-- 70.8 KB
fs_pin.c -rw-r--r-- 2.0 KB
fs_struct.c -rw-r--r-- 3.3 KB
inode.c -rw-r--r-- 55.1 KB
internal.h -rw-r--r-- 4.7 KB
ioctl.c -rw-r--r-- 17.3 KB
iomap.c -rw-r--r-- 25.4 KB
libfs.c -rw-r--r-- 30.6 KB
locks.c -rw-r--r-- 73.7 KB
mbcache.c -rw-r--r-- 11.8 KB
mount.h -rw-r--r-- 3.9 KB
mpage.c -rw-r--r-- 20.9 KB
namei.c -rw-r--r-- 121.1 KB
namespace.c -rw-r--r-- 85.5 KB
no-block.c -rw-r--r-- 688 bytes
nsfs.c -rw-r--r-- 5.6 KB
open.c -rw-r--r-- 28.4 KB
pipe.c -rw-r--r-- 27.3 KB
pnode.c -rw-r--r-- 15.3 KB
pnode.h -rw-r--r-- 1.9 KB
posix_acl.c -rw-r--r-- 21.4 KB
proc_namespace.c -rw-r--r-- 7.8 KB
read_write.c -rw-r--r-- 46.8 KB
readdir.c -rw-r--r-- 11.2 KB
select.c -rw-r--r-- 34.4 KB
seq_file.c -rw-r--r-- 22.8 KB
signalfd.c -rw-r--r-- 8.8 KB
splice.c -rw-r--r-- 39.6 KB
stack.c -rw-r--r-- 2.5 KB
stat.c -rw-r--r-- 19.2 KB
statfs.c -rw-r--r-- 9.4 KB
super.c -rw-r--r-- 39.0 KB
sync.c -rw-r--r-- 9.9 KB
timerfd.c -rw-r--r-- 13.4 KB
userfaultfd.c -rw-r--r-- 50.1 KB
utimes.c -rw-r--r-- 7.1 KB
xattr.c -rw-r--r-- 23.5 KB

back to top