Revision 36845663843fc59c5d794e3dc0641472e3e572da authored by Huang Shijie on 29 December 2020, 23:14:58 UTC, committed by Linus Torvalds on 29 December 2020, 23:36:49 UTC
Some graphic card has very big memory on chip, such as 32G bytes.
In the following case, it will cause overflow:
pool = gen_pool_create(PAGE_SHIFT, NUMA_NO_NODE);
ret = gen_pool_add(pool, 0x1000000, SZ_32G, NUMA_NO_NODE);
va = gen_pool_alloc(pool, SZ_4G);
The overflow occurs in gen_pool_alloc_algo_owner():
....
size = nbits << order;
....
The @nbits is "int" type, so it will overflow.
Then the gen_pool_avail() will return the wrong value.
This patch converts some "int" to "unsigned long", and
changes the compare code in while.
Link: https://lkml.kernel.org/r/20201229060657.3389-1-sjhuang@iluvatar.ai
Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
Reported-by: Shi Jiasheng <jiasheng.shi@iluvatar.ai>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent aa8c7db
| File | Mode | Size |
|---|---|---|
| include | ||
| .gitignore | -rw-r--r-- | 94 bytes |
| Kconfig | -rw-r--r-- | 7.7 KB |
| Makefile | -rw-r--r-- | 2.9 KB |
| default_cpio_list | -rw-r--r-- | 153 bytes |
| gen_init_cpio.c | -rw-r--r-- | 12.8 KB |
| gen_initramfs.sh | -rwxr-xr-x | 5.7 KB |
| initramfs_data.S | -rw-r--r-- | 1.2 KB |
Computing file changes ...
