Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision 3b3376f222e3ab58367d9dd405cafd09d5e37b7c authored by Lin Feng on 26 February 2021, 01:20:53 UTC, committed by Linus Torvalds on 26 February 2021, 17:41:03 UTC 
sysctl.c: fix underflow value setting risk in vm_table
 
Apart from subsystem specific .proc_handler handler, all ctl_tables with
extra1 and extra2 members set should use proc_dointvec_minmax instead of
proc_dointvec, or the limit set in extra* never work and potentially echo
underflow values(negative numbers) is likely make system unstable.

Especially vfs_cache_pressure and zone_reclaim_mode, -1 is apparently not
a valid value, but we can set to them.  And then kernel may crash.

# echo -1 > /proc/sys/vm/vfs_cache_pressure

Link: https://lkml.kernel.org/r/20201223105535.2875-1-linf@wangsu.com
Signed-off-by: Lin Feng <linf@wangsu.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 4508943
History
Tip revision: 3b3376f222e3ab58367d9dd405cafd09d5e37b7c authored by Lin Feng on 26 February 2021, 01:20:53 UTC
sysctl.c: fix underflow value setting risk in vm_table
Tip revision: 3b3376f
File Mode Size
acrn
auxdisplay
binderfs
bpf
configfs
connector
ftrace
hidraw
hw_breakpoint
kdb
kfifo
kmemleak
kobject
kprobes
livepatch
mei
nitro_enclaves
pidfd
pktgen
qmi
rpmsg
seccomp
timers
trace_events
trace_printk
uhid
v4l
vfio-mdev
vfs
watch_queue
watchdog
Kconfig -rw-r--r-- 6.7 KB
Makefile -rw-r--r-- 1.3 KB
back to top