Revision 3b7995a98ad76da5597b488fa84aa5a56d43b608 authored by Yang Yingliang on 18 December 2019, 08:44:04 UTC, committed by Jens Axboe on 20 December 2019, 18:52:01 UTC
When I doing fuzzy test, get the memleak report:
BUG: memory leak
unreferenced object 0xffff88837af80000 (size 4096):
comm "memleak", pid 3557, jiffies 4294817681 (age 112.499s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
20 00 00 00 10 01 00 00 00 00 00 00 01 00 00 00 ...............
backtrace:
[<000000001c894df8>] bio_alloc_bioset+0x393/0x590
[<000000008b139a3c>] bio_copy_user_iov+0x300/0xcd0
[<00000000a998bd8c>] blk_rq_map_user_iov+0x2f1/0x5f0
[<000000005ceb7f05>] blk_rq_map_user+0xf2/0x160
[<000000006454da92>] sg_common_write.isra.21+0x1094/0x1870
[<00000000064bb208>] sg_write.part.25+0x5d9/0x950
[<000000004fc670f6>] sg_write+0x5f/0x8c
[<00000000b0d05c7b>] __vfs_write+0x7c/0x100
[<000000008e177714>] vfs_write+0x1c3/0x500
[<0000000087d23f34>] ksys_write+0xf9/0x200
[<000000002c8dbc9d>] do_syscall_64+0x9f/0x4f0
[<00000000678d8e9a>] entry_SYSCALL_64_after_hwframe+0x49/0xbe
If __blk_rq_map_user_iov() is failed in blk_rq_map_user_iov(),
the bio(s) which is allocated before this failing will leak. The
refcount of the bio(s) is init to 1 and increased to 2 by calling
bio_get(), but __blk_rq_unmap_user() only decrease it to 1, so
the bio cannot be freed. Fix it by calling blk_rq_unmap_user().
Reviewed-by: Bob Liu <bob.liu@oracle.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent daa400f
| File | Mode | Size |
|---|---|---|
| partitions | ||
| Kconfig | -rw-r--r-- | 6.2 KB |
| Kconfig.iosched | -rw-r--r-- | 1.4 KB |
| Makefile | -rw-r--r-- | 1.6 KB |
| badblocks.c | -rw-r--r-- | 14.1 KB |
| bfq-cgroup.c | -rw-r--r-- | 37.4 KB |
| bfq-iosched.c | -rw-r--r-- | 236.1 KB |
| bfq-iosched.h | -rw-r--r-- | 36.6 KB |
| bfq-wf2q.c | -rw-r--r-- | 52.4 KB |
| bio-integrity.c | -rw-r--r-- | 12.3 KB |
| bio.c | -rw-r--r-- | 54.1 KB |
| blk-cgroup-rwstat.c | -rw-r--r-- | 3.4 KB |
| blk-cgroup-rwstat.h | -rw-r--r-- | 3.9 KB |
| blk-cgroup.c | -rw-r--r-- | 44.3 KB |
| blk-core.c | -rw-r--r-- | 48.7 KB |
| blk-exec.c | -rw-r--r-- | 2.6 KB |
| blk-flush.c | -rw-r--r-- | 15.0 KB |
| blk-integrity.c | -rw-r--r-- | 11.6 KB |
| blk-ioc.c | -rw-r--r-- | 10.2 KB |
| blk-iocost.c | -rw-r--r-- | 67.1 KB |
| blk-iolatency.c | -rw-r--r-- | 28.0 KB |
| blk-lib.c | -rw-r--r-- | 10.2 KB |
| blk-map.c | -rw-r--r-- | 6.0 KB |
| blk-merge.c | -rw-r--r-- | 24.5 KB |
| blk-mq-cpumap.c | -rw-r--r-- | 2.2 KB |
| blk-mq-debugfs-zoned.c | -rw-r--r-- | 435 bytes |
| blk-mq-debugfs.c | -rw-r--r-- | 24.4 KB |
| blk-mq-debugfs.h | -rw-r--r-- | 2.7 KB |
| blk-mq-pci.c | -rw-r--r-- | 1.3 KB |
| blk-mq-rdma.c | -rw-r--r-- | 1.3 KB |
| blk-mq-sched.c | -rw-r--r-- | 14.1 KB |
| blk-mq-sched.h | -rw-r--r-- | 2.5 KB |
| blk-mq-sysfs.c | -rw-r--r-- | 8.4 KB |
| blk-mq-tag.c | -rw-r--r-- | 15.0 KB |
| blk-mq-tag.h | -rw-r--r-- | 2.2 KB |
| blk-mq-virtio.c | -rw-r--r-- | 1.3 KB |
| blk-mq.c | -rw-r--r-- | 85.8 KB |
| blk-mq.h | -rw-r--r-- | 7.6 KB |
| blk-pm.c | -rw-r--r-- | 6.6 KB |
| blk-pm.h | -rw-r--r-- | 1.4 KB |
| blk-rq-qos.c | -rw-r--r-- | 7.1 KB |
| blk-rq-qos.h | -rw-r--r-- | 5.0 KB |
| blk-settings.c | -rw-r--r-- | 28.0 KB |
| blk-softirq.c | -rw-r--r-- | 3.7 KB |
| blk-stat.c | -rw-r--r-- | 4.6 KB |
| blk-stat.h | -rw-r--r-- | 4.6 KB |
| blk-sysfs.c | -rw-r--r-- | 26.3 KB |
| blk-throttle.c | -rw-r--r-- | 69.2 KB |
| blk-timeout.c | -rw-r--r-- | 3.8 KB |
| blk-wbt.c | -rw-r--r-- | 19.9 KB |
| blk-wbt.h | -rw-r--r-- | 2.9 KB |
| blk-zoned.c | -rw-r--r-- | 12.3 KB |
| blk.h | -rw-r--r-- | 10.7 KB |
| bounce.c | -rw-r--r-- | 9.3 KB |
| bsg-lib.c | -rw-r--r-- | 9.8 KB |
| bsg.c | -rw-r--r-- | 11.1 KB |
| cmdline-parser.c | -rw-r--r-- | 4.9 KB |
| compat_ioctl.c | -rw-r--r-- | 10.9 KB |
| elevator.c | -rw-r--r-- | 18.9 KB |
| genhd.c | -rw-r--r-- | 50.7 KB |
| ioctl.c | -rw-r--r-- | 14.6 KB |
| ioprio.c | -rw-r--r-- | 5.1 KB |
| kyber-iosched.c | -rw-r--r-- | 27.8 KB |
| mq-deadline.c | -rw-r--r-- | 20.6 KB |
| opal_proto.h | -rw-r--r-- | 9.3 KB |
| partition-generic.c | -rw-r--r-- | 15.3 KB |
| scsi_ioctl.c | -rw-r--r-- | 22.4 KB |
| sed-opal.c | -rw-r--r-- | 62.4 KB |
| t10-pi.c | -rw-r--r-- | 7.7 KB |
Computing file changes ...
