Revision 3d3be4333fdf6faa080947b331a6a19bce1a4f57 authored by Eric Dumazet on 01 September 2010, 00:50:51 UTC, committed by David S. Miller on 02 September 2010, 02:17:35 UTC
Packets entering GRO might have different headrooms, even for a given flow (because of implementation details in drivers, like copybreak). We cant force drivers to deliver packets with a fixed headroom. 1) fix skb_segment() skb_segment() makes the false assumption headrooms of fragments are same than the head. When CHECKSUM_PARTIAL is used, this can give csum_start errors, and crash later in skb_copy_and_csum_dev() 2) allocate a minimal skb for head of frag_list skb_gro_receive() uses netdev_alloc_skb(headroom + skb_gro_offset(p)) to allocate a fresh skb. This adds NET_SKB_PAD to a padding already provided by netdevice, depending on various things, like copybreak. Use alloc_skb() to allocate an exact padding, to reduce cache line needs: NET_SKB_PAD + NET_IP_ALIGN bugzilla : https://bugzilla.kernel.org/show_bug.cgi?id=16626 Many thanks to Plamen Petrov, testing many debugging patches ! With help of Jarek Poplawski. Reported-by: Plamen Petrov <pvp-lsts@fs.uni-ruse.bg> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> CC: Jarek Poplawski <jarkao2@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 87f94b4
File | Mode | Size |
---|---|---|
hw_breakpoint | ||
kobject | ||
kprobes | ||
trace_events | ||
tracepoints | ||
Kconfig | -rw-r--r-- | 1.2 KB |
Makefile | -rw-r--r-- | 128 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...