Revision 3f758e844aa9800eb660d60ee10226fa802594d4 authored by Paolo Valente on 07 August 2019, 14:17:54 UTC, committed by Jens Axboe on 08 August 2019, 13:30:52 UTC
Since commit 13a857a4c4e8 ("block, bfq: detect wakers and
unconditionally inject their I/O"), every bfq_queue has a pointer to a
waker bfq_queue and a list of the bfq_queues it may wake. In this
respect, when a bfq_queue, say Q, remains with no I/O source attached
to it, Q cannot be woken by any other bfq_queue, and cannot wake any
other bfq_queue. Then Q must be removed from the woken list of its
possible waker bfq_queue, and all bfq_queues in the woken list of Q
must stop having a waker bfq_queue.

Q remains with no I/O source in two cases: when the last process
associated with Q exits or when such a process gets associated with a
different bfq_queue. Unfortunately, commit 13a857a4c4e8 ("block, bfq:
detect wakers and unconditionally inject their I/O") performed the
above updates only in the first case.

This commit fixes this bug by moving these updates to when Q gets
freed. This is a simple and safe way to handle all cases, as both the
above events, process exit and re-association, lead to Q being freed
soon, and because dangling references would come out only after Q gets
freed (if no update were performed).

Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
Reported-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 08d383a
History
File Mode Size
Kconfig -rw-r--r-- 69.5 KB
Makefile -rw-r--r-- 1.2 KB
calibrate.c -rw-r--r-- 8.6 KB
do_mounts.c -rw-r--r-- 14.8 KB
do_mounts.h -rw-r--r-- 1.1 KB
do_mounts_initrd.c -rw-r--r-- 3.5 KB
do_mounts_md.c -rw-r--r-- 7.9 KB
do_mounts_rd.c -rw-r--r-- 8.1 KB
init_task.c -rw-r--r-- 5.3 KB
initramfs.c -rw-r--r-- 14.3 KB
main.c -rw-r--r-- 30.1 KB
noinitramfs.c -rw-r--r-- 873 bytes
version.c -rw-r--r-- 1.3 KB

back to top