Skip to main content

Browse the archive

https://github.com/torvalds/linux
27 March 2024, 02:37:15 UTC
Revision 40088dc4e1ead7df31728c73f5b51d71da18831d authored by Takashi Iwai on 12 March 2018, 12:55:48 UTC, committed by Takashi Iwai on 12 March 2018, 13:16:08 UTC 
ALSA: hda - Revert power_save option default value
 
With the commit 1ba8f9d30817 ("ALSA: hda: Add a power_save
blacklist"), we changed the default value of power_save option to -1
for processing the power-save blacklist.
Unfortunately, this seems breaking user-space applications that
actually read the power_save parameter value via sysfs and judge /
adjust the power-saving status.  They see the value -1 as if the
power-save is turned off, although the actual value is taken from
CONFIG_SND_HDA_POWER_SAVE_DEFAULT and it can be a positive.

So, overall, passing -1 there was no good idea.  Let's partially
revert it -- at least for power_save option default value is restored
again to CONFIG_SND_HDA_POWER_SAVE_DEFAULT.  Meanwhile, in this patch,
we keep the blacklist behavior and make is adjustable via the new
option, pm_blacklist.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199073
Fixes: 1ba8f9d30817 ("ALSA: hda: Add a power_save blacklist")
Acked-by: Hans de Goede <hdegoede@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 01c0b42
History
Tip revision: 40088dc4e1ead7df31728c73f5b51d71da18831d authored by Takashi Iwai on 12 March 2018, 12:55:48 UTC
ALSA: hda - Revert power_save option default value
Tip revision: 40088dc
File Mode Size
apparmor
integrity
keys
loadpin
selinux
smack
tomoyo
yama
Kconfig -rw-r--r-- 9.8 KB
Makefile -rw-r--r-- 1.0 KB
commoncap.c -rw-r--r-- 38.9 KB
device_cgroup.c -rw-r--r-- 20.4 KB
inode.c -rw-r--r-- 10.5 KB
lsm_audit.c -rw-r--r-- 10.7 KB
min_addr.c -rw-r--r-- 1.3 KB
security.c -rw-r--r-- 43.5 KB
back to top