Revision 45f38e4c17379c83be5533ff60697ac888d8eea7 authored by Frank Liberato on 21 September 2018, 18:34:39 UTC, committed by Blink WPT Bot on 21 September 2018, 18:44:44 UTC
This reverts commit 254369a5f6df06c2c6be067d14c2cb2a036ba173.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> bindings: Implement timers with V8Function
>
> This fixes bug 866610 by using the IDL infrastructure to properly enter
> the v8::Context before calling the registered callback.
>
> Also ensure eager finalization of ScheduledAction in DOMTimer to
> prevent a memory leak. Added two more effective DCHECKs to confirm.
>
> Bug: 866610
> Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1
> Reviewed-on: https://chromium-review.googlesource.com/1220486
> Reviewed-by: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Commit-Queue: Timothy Gu <timothygu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593108}
TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org
Change-Id: Ifaccc3374466b851fc28b10c63ed1397bdae635e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866610
Reviewed-on: https://chromium-review.googlesource.com/1239216
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593260}
1 parent 2719d8f
| File | Mode | Size |
|---|---|---|
| resources | ||
| 304.htm | -rw-r--r-- | 3.3 KB |
| META.yml | -rw-r--r-- | 132 bytes |
| README.md | -rw-r--r-- | 200 bytes |
| access-control-expose-headers-parsing.window.js | -rw-r--r-- | 512 bytes |
| allow-headers.htm | -rw-r--r-- | 3.1 KB |
| basic.htm | -rw-r--r-- | 2.2 KB |
| client-hint-request-headers.htm | -rw-r--r-- | 3.1 KB |
| credentials-flag.htm | -rw-r--r-- | 4.1 KB |
| image-tainting-in-cross-origin-iframe.sub.html | -rw-r--r-- | 893 bytes |
| late-upload-events.htm | -rw-r--r-- | 1.4 KB |
| origin.htm | -rw-r--r-- | 4.4 KB |
| preflight-cache.htm | -rw-r--r-- | 4.4 KB |
| preflight-failure.htm | -rw-r--r-- | 1.8 KB |
| redirect-origin.htm | -rw-r--r-- | 6.8 KB |
| redirect-preflight-2.htm | -rw-r--r-- | 2.1 KB |
| redirect-preflight.htm | -rw-r--r-- | 1.5 KB |
| redirect-userinfo.htm | -rw-r--r-- | 3.3 KB |
| remote-origin.htm | -rw-r--r-- | 3.7 KB |
| request-headers.htm | -rw-r--r-- | 2.8 KB |
| response-headers.htm | -rw-r--r-- | 3.9 KB |
| script-304.html | -rw-r--r-- | 1.1 KB |
| simple-requests.htm | -rw-r--r-- | 3.4 KB |
| status-async.htm | -rw-r--r-- | 4.4 KB |
| status-preflight.htm | -rw-r--r-- | 2.0 KB |
| status.htm | -rw-r--r-- | 2.4 KB |
| support.js | -rw-r--r-- | 843 bytes |
Computing file changes ...
