Revision 45f38e4c17379c83be5533ff60697ac888d8eea7 authored by Frank Liberato on 21 September 2018, 18:34:39 UTC, committed by Blink WPT Bot on 21 September 2018, 18:44:44 UTC
This reverts commit 254369a5f6df06c2c6be067d14c2cb2a036ba173. Reason for revert: <INSERT REASONING HERE> Original change's description: > bindings: Implement timers with V8Function > > This fixes bug 866610 by using the IDL infrastructure to properly enter > the v8::Context before calling the registered callback. > > Also ensure eager finalization of ScheduledAction in DOMTimer to > prevent a memory leak. Added two more effective DCHECKs to confirm. > > Bug: 866610 > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1 > Reviewed-on: https://chromium-review.googlesource.com/1220486 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Timothy Gu <timothygu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593108} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org Change-Id: Ifaccc3374466b851fc28b10c63ed1397bdae635e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866610 Reviewed-on: https://chromium-review.googlesource.com/1239216 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593260}
1 parent 2719d8f
File | Mode | Size |
---|---|---|
chromium | ||
test | ||
webidl2 | ||
.gitignore | -rw-r--r-- | 36 bytes |
.htaccess | -rw-r--r-- | 107 bytes |
LICENSE | -rw-r--r-- | 1.5 KB |
META.yml | -rw-r--r-- | 47 bytes |
check-layout-th.js | -rw-r--r-- | 7.7 KB |
idlharness.js | -rw-r--r-- | 122.9 KB |
idlharness.js.headers | -rw-r--r-- | 73 bytes |
readme.md | -rw-r--r-- | 847 bytes |
sriharness.js | -rw-r--r-- | 3.4 KB |
testdriver-vendor.js | -rw-r--r-- | 0 bytes |
testdriver-vendor.js.headers | -rw-r--r-- | 73 bytes |
testdriver.js | -rw-r--r-- | 7.8 KB |
testdriver.js.headers | -rw-r--r-- | 73 bytes |
testharness.css.headers | -rw-r--r-- | 65 bytes |
testharness.js | -rw-r--r-- | 118.3 KB |
testharness.js.headers | -rw-r--r-- | 73 bytes |
testharnessreport.js | -rw-r--r-- | 2.2 KB |
testharnessreport.js.headers | -rw-r--r-- | 73 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...