Revision 483b4ee60edbefdfbff0dd538fb81f368d9e7c0d authored by Suresh Siddha on 04 February 2009, 19:59:44 UTC, committed by Ingo Molnar on 04 February 2009, 21:31:19 UTC
Christian Borntraeger reports: > After a logical cpu offline, even on a complete idle system, there > is one cpu with full ticks. It turns out that nohz.cpu_mask has the > the offlined cpu still set. > > In select_nohz_load_balancer() we check if the system is completely > idle to turn of load balancing. We compare cpu_online_map with > nohz.cpu_mask. Since cpu_online_map is updated on cpu unplug, > but nohz.cpu_mask is not, the check fails and the scheduler believes > that we need an "idle load balancer" even on a fully idle system. > Since the ilb cpu does not deactivate the timer tick this breaks NOHZ. Fix the select_nohz_load_balancer() to not set the nohz.cpu_mask while a cpu is going offline. Reported-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
1 parent 3562612
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 6.5 KB |
Makefile | -rw-r--r-- | 1.3 KB |
allocpercpu.c | -rw-r--r-- | 4.0 KB |
backing-dev.c | -rw-r--r-- | 7.0 KB |
bootmem.c | -rw-r--r-- | 17.8 KB |
bounce.c | -rw-r--r-- | 6.5 KB |
dmapool.c | -rw-r--r-- | 12.9 KB |
fadvise.c | -rw-r--r-- | 3.3 KB |
failslab.c | -rw-r--r-- | 1.3 KB |
filemap.c | -rw-r--r-- | 65.0 KB |
filemap_xip.c | -rw-r--r-- | 11.0 KB |
fremap.c | -rw-r--r-- | 6.7 KB |
highmem.c | -rw-r--r-- | 8.7 KB |
hugetlb.c | -rw-r--r-- | 60.1 KB |
internal.h | -rw-r--r-- | 7.9 KB |
maccess.c | -rw-r--r-- | 1.4 KB |
madvise.c | -rw-r--r-- | 9.5 KB |
memcontrol.c | -rw-r--r-- | 56.9 KB |
memory.c | -rw-r--r-- | 86.1 KB |
memory_hotplug.c | -rw-r--r-- | 20.8 KB |
mempolicy.c | -rw-r--r-- | 59.3 KB |
mempool.c | -rw-r--r-- | 9.0 KB |
migrate.c | -rw-r--r-- | 25.7 KB |
mincore.c | -rw-r--r-- | 5.7 KB |
mlock.c | -rw-r--r-- | 16.5 KB |
mm_init.c | -rw-r--r-- | 3.7 KB |
mmap.c | -rw-r--r-- | 64.1 KB |
mmu_notifier.c | -rw-r--r-- | 8.2 KB |
mmzone.c | -rw-r--r-- | 1.5 KB |
mprotect.c | -rw-r--r-- | 7.5 KB |
mremap.c | -rw-r--r-- | 11.1 KB |
msync.c | -rw-r--r-- | 2.4 KB |
nommu.c | -rw-r--r-- | 45.9 KB |
oom_kill.c | -rw-r--r-- | 16.4 KB |
page-writeback.c | -rw-r--r-- | 39.3 KB |
page_alloc.c | -rw-r--r-- | 130.2 KB |
page_cgroup.c | -rw-r--r-- | 10.5 KB |
page_io.c | -rw-r--r-- | 3.4 KB |
page_isolation.c | -rw-r--r-- | 3.6 KB |
pagewalk.c | -rw-r--r-- | 3.2 KB |
pdflush.c | -rw-r--r-- | 6.6 KB |
prio_tree.c | -rw-r--r-- | 6.3 KB |
quicklist.c | -rw-r--r-- | 2.4 KB |
readahead.c | -rw-r--r-- | 13.4 KB |
rmap.c | -rw-r--r-- | 34.2 KB |
shmem.c | -rw-r--r-- | 67.9 KB |
shmem_acl.c | -rw-r--r-- | 4.6 KB |
slab.c | -rw-r--r-- | 115.1 KB |
slob.c | -rw-r--r-- | 15.9 KB |
slub.c | -rw-r--r-- | 105.9 KB |
sparse-vmemmap.c | -rw-r--r-- | 4.2 KB |
sparse.c | -rw-r--r-- | 16.2 KB |
swap.c | -rw-r--r-- | 14.5 KB |
swap_state.c | -rw-r--r-- | 10.1 KB |
swapfile.c | -rw-r--r-- | 50.5 KB |
thrash.c | -rw-r--r-- | 2.0 KB |
truncate.c | -rw-r--r-- | 13.0 KB |
util.c | -rw-r--r-- | 3.9 KB |
vmalloc.c | -rw-r--r-- | 43.0 KB |
vmscan.c | -rw-r--r-- | 72.6 KB |
vmstat.c | -rw-r--r-- | 22.8 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...