Revision 4d96ba3530750fae3f3f01150adfecde96157815 authored by Roman Gushchin on 12 July 2019, 03:56:31 UTC, committed by Linus Torvalds on 12 July 2019, 18:05:44 UTC
Every slab page charged to a non-root memory cgroup has a pointer to the
memory cgroup and holds a reference to it, which protects a non-empty
memory cgroup from being released.  At the same time the page has a
pointer to the corresponding kmem_cache, and also hold a reference to the
kmem_cache.  And kmem_cache by itself holds a reference to the cgroup.

So there is clearly some redundancy, which allows to stop setting the
page->mem_cgroup pointer and rely on getting memcg pointer indirectly via
kmem_cache.  Further it will allow to change this pointer easier, without
a need to go over all charged pages.

So let's stop setting page->mem_cgroup pointer for slab pages, and stop
using the css refcounter directly for protecting the memory cgroup from
going away.  Instead rely on kmem_cache as an intermediate object.

Make sure that vmstats and shrinker lists are working as previously, as
well as /proc/kpagecgroup interface.

Link: http://lkml.kernel.org/r/20190611231813.3148843-10-guro@fb.com
Signed-off-by: Roman Gushchin <guro@fb.com>
Acked-by: Vladimir Davydov <vdavydov.dev@gmail.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Waiman Long <longman@redhat.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Andrei Vagin <avagin@gmail.com>
Cc: Qian Cai <cai@lca.pw>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent f0a3a24
History
File Mode Size
kasan
Kconfig -rw-r--r-- 24.8 KB
Kconfig.debug -rw-r--r-- 4.6 KB
Makefile -rw-r--r-- 3.7 KB
backing-dev.c -rw-r--r-- 27.0 KB
balloon_compaction.c -rw-r--r-- 5.5 KB
cleancache.c -rw-r--r-- 9.8 KB
cma.c -rw-r--r-- 14.0 KB
cma.h -rw-r--r-- 573 bytes
cma_debug.c -rw-r--r-- 4.5 KB
compaction.c -rw-r--r-- 75.0 KB
debug.c -rw-r--r-- 5.9 KB
debug_page_ref.c -rw-r--r-- 1.4 KB
dmapool.c -rw-r--r-- 13.7 KB
early_ioremap.c -rw-r--r-- 6.8 KB
fadvise.c -rw-r--r-- 5.3 KB
failslab.c -rw-r--r-- 1.4 KB
filemap.c -rw-r--r-- 96.5 KB
frame_vector.c -rw-r--r-- 6.4 KB
frontswap.c -rw-r--r-- 14.2 KB
gup.c -rw-r--r-- 60.9 KB
gup_benchmark.c -rw-r--r-- 2.7 KB
highmem.c -rw-r--r-- 11.7 KB
hmm.c -rw-r--r-- 42.3 KB
huge_memory.c -rw-r--r-- 82.7 KB
hugetlb.c -rw-r--r-- 135.4 KB
hugetlb_cgroup.c -rw-r--r-- 10.9 KB
hwpoison-inject.c -rw-r--r-- 3.2 KB
init-mm.c -rw-r--r-- 1.2 KB
internal.h -rw-r--r-- 17.1 KB
interval_tree.c -rw-r--r-- 3.1 KB
khugepaged.c -rw-r--r-- 48.2 KB
kmemleak-test.c -rw-r--r-- 2.6 KB
kmemleak.c -rw-r--r-- 59.6 KB
ksm.c -rw-r--r-- 89.5 KB
list_lru.c -rw-r--r-- 14.6 KB
maccess.c -rw-r--r-- 3.1 KB
madvise.c -rw-r--r-- 23.0 KB
memblock.c -rw-r--r-- 56.5 KB
memcontrol.c -rw-r--r-- 175.2 KB
memfd.c -rw-r--r-- 7.8 KB
memory-failure.c -rw-r--r-- 51.9 KB
memory.c -rw-r--r-- 127.1 KB
memory_hotplug.c -rw-r--r-- 48.6 KB
mempolicy.c -rw-r--r-- 72.4 KB
mempool.c -rw-r--r-- 15.8 KB
memtest.c -rw-r--r-- 2.8 KB
migrate.c -rw-r--r-- 76.9 KB
mincore.c -rw-r--r-- 7.5 KB
mlock.c -rw-r--r-- 22.7 KB
mm_init.c -rw-r--r-- 4.8 KB
mmap.c -rw-r--r-- 100.2 KB
mmu_context.c -rw-r--r-- 1.3 KB
mmu_gather.c -rw-r--r-- 6.8 KB
mmu_notifier.c -rw-r--r-- 11.7 KB
mmzone.c -rw-r--r-- 2.4 KB
mprotect.c -rw-r--r-- 15.6 KB
mremap.c -rw-r--r-- 19.4 KB
msync.c -rw-r--r-- 2.6 KB
nommu.c -rw-r--r-- 47.9 KB
oom_kill.c -rw-r--r-- 30.2 KB
page-writeback.c -rw-r--r-- 84.7 KB
page_alloc.c -rw-r--r-- 235.2 KB
page_counter.c -rw-r--r-- 6.6 KB
page_ext.c -rw-r--r-- 11.0 KB
page_idle.c -rw-r--r-- 5.5 KB
page_io.c -rw-r--r-- 10.5 KB
page_isolation.c -rw-r--r-- 9.2 KB
page_owner.c -rw-r--r-- 14.7 KB
page_poison.c -rw-r--r-- 3.0 KB
page_vma_mapped.c -rw-r--r-- 7.6 KB
pagewalk.c -rw-r--r-- 8.7 KB
percpu-internal.h -rw-r--r-- 6.3 KB
percpu-km.c -rw-r--r-- 3.0 KB
percpu-stats.c -rw-r--r-- 5.7 KB
percpu-vm.c -rw-r--r-- 10.3 KB
percpu.c -rw-r--r-- 92.4 KB
pgtable-generic.c -rw-r--r-- 5.3 KB
process_vm_access.c -rw-r--r-- 9.8 KB
quicklist.c -rw-r--r-- 2.4 KB
readahead.c -rw-r--r-- 16.5 KB
rmap.c -rw-r--r-- 53.7 KB
rodata_test.c -rw-r--r-- 1.3 KB
shmem.c -rw-r--r-- 105.0 KB
shuffle.c -rw-r--r-- 5.7 KB
shuffle.h -rw-r--r-- 1.5 KB
slab.c -rw-r--r-- 105.0 KB
slab.h -rw-r--r-- 16.1 KB
slab_common.c -rw-r--r-- 40.9 KB
slob.c -rw-r--r-- 17.0 KB
slub.c -rw-r--r-- 142.3 KB
sparse-vmemmap.c -rw-r--r-- 6.6 KB
sparse.c -rw-r--r-- 21.5 KB
swap.c -rw-r--r-- 28.6 KB
swap_cgroup.c -rw-r--r-- 5.2 KB
swap_slots.c -rw-r--r-- 9.4 KB
swap_state.c -rw-r--r-- 22.4 KB
swapfile.c -rw-r--r-- 94.7 KB
truncate.c -rw-r--r-- 26.4 KB
usercopy.c -rw-r--r-- 9.3 KB
userfaultfd.c -rw-r--r-- 15.8 KB
util.c -rw-r--r-- 19.0 KB
vmacache.c -rw-r--r-- 2.7 KB
vmalloc.c -rw-r--r-- 86.7 KB
vmpressure.c -rw-r--r-- 13.8 KB
vmscan.c -rw-r--r-- 121.6 KB
vmstat.c -rw-r--r-- 51.5 KB
workingset.c -rw-r--r-- 19.2 KB
z3fold.c -rw-r--r-- 39.5 KB
zbud.c -rw-r--r-- 18.2 KB
zpool.c -rw-r--r-- 10.7 KB
zsmalloc.c -rw-r--r-- 60.4 KB
zswap.c -rw-r--r-- 34.2 KB

back to top