Revision 4dda864d73079a1eb01fab4ec29b97db150163bf authored by Geert Uytterhoeven on 28 October 2016, 12:07:47 UTC, committed by Greg Kroah-Hartman on 28 October 2016, 12:13:07 UTC
The port->console flag is always false, as uart_console() is called before the serial console has been registered. Hence for a serial port used as the console, uart_tty_port_shutdown() will still be called when userspace closes the port, powering it down. This may lead to a system lock up when the serial console driver writes to the serial port's registers. To fix this, move the setting of port->console after the call to uart_configure_port(), which registers the serial console. Fixes: 761ed4a94582ab29 ("tty: serial_core: convert uart_close to use tty_port_close") Reported-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Rob Herring <robh@kernel.org> Tested-by: Mugunthan V N <mugunthanvnm@ti.com> Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> [robh: rebased on tty-linus] Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 9bcffe7
File | Mode | Size |
---|---|---|
devices | ||
switches | ||
Kconfig | -rw-r--r-- | 2.9 KB |
Makefile | -rw-r--r-- | 352 bytes |
rio-access.c | -rw-r--r-- | 5.5 KB |
rio-driver.c | -rw-r--r-- | 6.9 KB |
rio-scan.c | -rw-r--r-- | 31.3 KB |
rio-sysfs.c | -rw-r--r-- | 8.4 KB |
rio.c | -rw-r--r-- | 63.6 KB |
rio.h | -rw-r--r-- | 2.7 KB |
rio_cm.c | -rw-r--r-- | 54.2 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...