Revision 4e43e64d0f1332fcc503babad4dc31aead7131ca authored by Eric Dumazet on 28 June 2022, 12:12:48 UTC, committed by Jakub Kicinski on 30 June 2022, 03:41:09 UTC
As reported by syzbot, we should not use rcu_dereference() when rcu_read_lock() is not held. WARNING: suspicious RCU usage 5.19.0-rc2-syzkaller #0 Not tainted net/ipv6/addrconf.c:5175 suspicious rcu_dereference_check() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 1 lock held by syz-executor326/3617: #0: ffffffff8d5848e8 (rtnl_mutex){+.+.}-{3:3}, at: netlink_dump+0xae/0xc20 net/netlink/af_netlink.c:2223 stack backtrace: CPU: 0 PID: 3617 Comm: syz-executor326 Not tainted 5.19.0-rc2-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 in6_dump_addrs+0x12d1/0x1790 net/ipv6/addrconf.c:5175 inet6_dump_addr+0x9c1/0xb50 net/ipv6/addrconf.c:5300 netlink_dump+0x541/0xc20 net/netlink/af_netlink.c:2275 __netlink_dump_start+0x647/0x900 net/netlink/af_netlink.c:2380 netlink_dump_start include/linux/netlink.h:245 [inline] rtnetlink_rcv_msg+0x73e/0xc90 net/core/rtnetlink.c:6046 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2501 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline] netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345 netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:734 ____sys_sendmsg+0x6eb/0x810 net/socket.c:2492 ___sys_sendmsg+0xf3/0x170 net/socket.c:2546 __sys_sendmsg net/socket.c:2575 [inline] __do_sys_sendmsg net/socket.c:2584 [inline] __se_sys_sendmsg net/socket.c:2582 [inline] __x64_sys_sendmsg+0x132/0x220 net/socket.c:2582 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x46/0xb0 Fixes: 88e2ca308094 ("mld: convert ifmcaddr6 to RCU") Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Taehee Yoo <ap420073@gmail.com> Link: https://lore.kernel.org/r/20220628121248.858695-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent fa152f6
File | Mode | Size |
---|---|---|
damon | ||
kasan | ||
kfence | ||
Kconfig | -rw-r--r-- | 35.0 KB |
Kconfig.debug | -rw-r--r-- | 7.7 KB |
Makefile | -rw-r--r-- | 4.9 KB |
backing-dev.c | -rw-r--r-- | 24.7 KB |
balloon_compaction.c | -rw-r--r-- | 8.2 KB |
bootmem_info.c | -rw-r--r-- | 3.3 KB |
cma.c | -rw-r--r-- | 15.5 KB |
cma.h | -rw-r--r-- | 1.4 KB |
cma_debug.c | -rw-r--r-- | 4.5 KB |
cma_sysfs.c | -rw-r--r-- | 2.4 KB |
compaction.c | -rw-r--r-- | 84.1 KB |
debug.c | -rw-r--r-- | 6.8 KB |
debug_page_ref.c | -rw-r--r-- | 1.4 KB |
debug_vm_pgtable.c | -rw-r--r-- | 38.8 KB |
dmapool.c | -rw-r--r-- | 13.6 KB |
early_ioremap.c | -rw-r--r-- | 6.7 KB |
fadvise.c | -rw-r--r-- | 5.5 KB |
failslab.c | -rw-r--r-- | 1.4 KB |
filemap.c | -rw-r--r-- | 111.5 KB |
folio-compat.c | -rw-r--r-- | 3.9 KB |
frontswap.c | -rw-r--r-- | 7.9 KB |
gup.c | -rw-r--r-- | 88.3 KB |
gup_test.c | -rw-r--r-- | 5.6 KB |
gup_test.h | -rw-r--r-- | 938 bytes |
highmem.c | -rw-r--r-- | 19.5 KB |
hmm.c | -rw-r--r-- | 16.7 KB |
huge_memory.c | -rw-r--r-- | 84.4 KB |
hugetlb.c | -rw-r--r-- | 199.2 KB |
hugetlb_cgroup.c | -rw-r--r-- | 24.6 KB |
hugetlb_vmemmap.c | -rw-r--r-- | 6.2 KB |
hugetlb_vmemmap.h | -rw-r--r-- | 1.2 KB |
hwpoison-inject.c | -rw-r--r-- | 2.7 KB |
init-mm.c | -rw-r--r-- | 1.6 KB |
internal.h | -rw-r--r-- | 27.0 KB |
interval_tree.c | -rw-r--r-- | 3.1 KB |
io-mapping.c | -rw-r--r-- | 993 bytes |
ioremap.c | -rw-r--r-- | 1.2 KB |
khugepaged.c | -rw-r--r-- | 60.2 KB |
kmemleak.c | -rw-r--r-- | 57.0 KB |
ksm.c | -rw-r--r-- | 89.1 KB |
list_lru.c | -rw-r--r-- | 13.8 KB |
maccess.c | -rw-r--r-- | 5.8 KB |
madvise.c | -rw-r--r-- | 37.6 KB |
mapping_dirty_helpers.c | -rw-r--r-- | 10.5 KB |
memblock.c | -rw-r--r-- | 60.6 KB |
memcontrol.c | -rw-r--r-- | 196.3 KB |
memfd.c | -rw-r--r-- | 8.2 KB |
memory-failure.c | -rw-r--r-- | 62.6 KB |
memory.c | -rw-r--r-- | 157.9 KB |
memory_hotplug.c | -rw-r--r-- | 64.1 KB |
mempolicy.c | -rw-r--r-- | 77.8 KB |
mempool.c | -rw-r--r-- | 15.8 KB |
memremap.c | -rw-r--r-- | 14.1 KB |
memtest.c | -rw-r--r-- | 2.8 KB |
migrate.c | -rw-r--r-- | 66.9 KB |
migrate_device.c | -rw-r--r-- | 21.7 KB |
mincore.c | -rw-r--r-- | 7.1 KB |
mlock.c | -rw-r--r-- | 19.0 KB |
mm_init.c | -rw-r--r-- | 5.3 KB |
mmap.c | -rw-r--r-- | 102.0 KB |
mmap_lock.c | -rw-r--r-- | 6.2 KB |
mmu_gather.c | -rw-r--r-- | 8.8 KB |
mmu_notifier.c | -rw-r--r-- | 35.3 KB |
mmzone.c | -rw-r--r-- | 2.5 KB |
mprotect.c | -rw-r--r-- | 20.9 KB |
mremap.c | -rw-r--r-- | 28.1 KB |
msync.c | -rw-r--r-- | 2.8 KB |
nommu.c | -rw-r--r-- | 44.4 KB |
oom_kill.c | -rw-r--r-- | 33.5 KB |
page-writeback.c | -rw-r--r-- | 91.8 KB |
page_alloc.c | -rw-r--r-- | 265.1 KB |
page_counter.c | -rw-r--r-- | 6.7 KB |
page_ext.c | -rw-r--r-- | 11.2 KB |
page_idle.c | -rw-r--r-- | 5.2 KB |
page_io.c | -rw-r--r-- | 12.7 KB |
page_isolation.c | -rw-r--r-- | 20.6 KB |
page_owner.c | -rw-r--r-- | 16.9 KB |
page_poison.c | -rw-r--r-- | 2.5 KB |
page_reporting.c | -rw-r--r-- | 10.3 KB |
page_reporting.h | -rw-r--r-- | 1.6 KB |
page_table_check.c | -rw-r--r-- | 5.8 KB |
page_vma_mapped.c | -rw-r--r-- | 8.6 KB |
pagewalk.c | -rw-r--r-- | 15.5 KB |
percpu-internal.h | -rw-r--r-- | 7.0 KB |
percpu-km.c | -rw-r--r-- | 3.2 KB |
percpu-stats.c | -rw-r--r-- | 5.8 KB |
percpu-vm.c | -rw-r--r-- | 11.7 KB |
percpu.c | -rw-r--r-- | 102.5 KB |
pgalloc-track.h | -rw-r--r-- | 1.3 KB |
pgtable-generic.c | -rw-r--r-- | 5.8 KB |
process_vm_access.c | -rw-r--r-- | 8.2 KB |
ptdump.c | -rw-r--r-- | 4.2 KB |
readahead.c | -rw-r--r-- | 25.2 KB |
rmap.c | -rw-r--r-- | 72.6 KB |
rodata_test.c | -rw-r--r-- | 1.3 KB |
secretmem.c | -rw-r--r-- | 6.0 KB |
shmem.c | -rw-r--r-- | 108.5 KB |
shuffle.c | -rw-r--r-- | 4.7 KB |
shuffle.h | -rw-r--r-- | 1.2 KB |
slab.c | -rw-r--r-- | 105.9 KB |
slab.h | -rw-r--r-- | 23.0 KB |
slab_common.c | -rw-r--r-- | 33.1 KB |
slob.c | -rw-r--r-- | 18.6 KB |
slub.c | -rw-r--r-- | 155.5 KB |
sparse-vmemmap.c | -rw-r--r-- | 20.2 KB |
sparse.c | -rw-r--r-- | 25.7 KB |
swap.c | -rw-r--r-- | 31.8 KB |
swap.h | -rw-r--r-- | 4.1 KB |
swap_cgroup.c | -rw-r--r-- | 5.1 KB |
swap_slots.c | -rw-r--r-- | 9.2 KB |
swap_state.c | -rw-r--r-- | 24.4 KB |
swapfile.c | -rw-r--r-- | 92.1 KB |
truncate.c | -rw-r--r-- | 26.2 KB |
usercopy.c | -rw-r--r-- | 8.1 KB |
userfaultfd.c | -rw-r--r-- | 18.5 KB |
util.c | -rw-r--r-- | 30.5 KB |
vmacache.c | -rw-r--r-- | 2.7 KB |
vmalloc.c | -rw-r--r-- | 106.6 KB |
vmpressure.c | -rw-r--r-- | 13.9 KB |
vmscan.c | -rw-r--r-- | 137.5 KB |
vmstat.c | -rw-r--r-- | 55.0 KB |
workingset.c | -rw-r--r-- | 21.8 KB |
z3fold.c | -rw-r--r-- | 46.0 KB |
zbud.c | -rw-r--r-- | 18.4 KB |
zpool.c | -rw-r--r-- | 11.2 KB |
zsmalloc.c | -rw-r--r-- | 58.1 KB |
zswap.c | -rw-r--r-- | 39.9 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...