Revision 4e5f09f89e6f1976dd49a57ba46cd447c7e19a1e authored by Alex Moshchuk on 13 April 2018, 15:22:14 UTC, committed by Chromium WPT Sync on 13 April 2018, 15:22:14 UTC
Changes from original attempt at https://crrev.com/c/999182:
- fix flakiness in two additional ChromeOS login tests
- fix CSP WPT tests to not depend on ordering between iframe's onload
  and postMessage - see https://crbug.com/832319.

Previously, we sent the IPC to forward a cross-process postMessage
immediately.  This caused a behavioral difference from the
same-process case where the postMessage is always scheduled.  Namely,
in a scenario like this:

  frame.postMessage(...);
  doSomethingThatSendsIPCsToFrame(frame);

the IPCs from JS following the postMessage would've been ordered
incorrectly, causing |frame| to see their side effects after the
postMessage dispatch in the cross-process case, whereas they would be
seen before the postMessage dispatch in the same-process case.  One
example of this is frame.focus(), and another is a frame element
onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
a postMessage dispatched from an inline script while the frame was
still loading.

To resolve these ordering concerns, this CL changes cross-process
postMessage to do a PostTask on the sender side before sending the
message to the browser process.  This improves the current state of
the world, but does not yet achieve a perfect match for the IPC
ordering in the same-process case - see discussion on the bug.

Bug: 828529
Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
Reviewed-on: https://chromium-review.googlesource.com/999182
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550284}
Reviewed-on: https://chromium-review.googlesource.com/1011287
Cr-Commit-Position: refs/heads/master@{#550621}
1 parent f90d3d6
History
File Mode Size
OWNERS -rw-r--r-- 27 bytes
green-ref.html -rw-r--r-- 273 bytes
historical.html -rw-r--r-- 535 bytes
interfaces.any.js -rw-r--r-- 526 bytes
webkit-appearance.tentative.html -rw-r--r-- 1.7 KB
webkit-background-origin-text-ref.html -rw-r--r-- 306 bytes
webkit-background-origin-text.html -rw-r--r-- 585 bytes
webkit-linear-gradient-line-bottom.html -rw-r--r-- 704 bytes
webkit-linear-gradient-line-left.html -rw-r--r-- 700 bytes
webkit-linear-gradient-line-right.html -rw-r--r-- 702 bytes
webkit-linear-gradient-line-top.html -rw-r--r-- 698 bytes
webkit-text-fill-color-currentColor.html -rw-r--r-- 750 bytes
webkit-text-fill-color-property-001-ref.html -rw-r--r-- 285 bytes
webkit-text-fill-color-property-001a.html -rw-r--r-- 521 bytes
webkit-text-fill-color-property-001b.html -rw-r--r-- 533 bytes
webkit-text-fill-color-property-001c.html -rw-r--r-- 565 bytes
webkit-text-fill-color-property-001d.html -rw-r--r-- 541 bytes
webkit-text-fill-color-property-002-ref.html -rw-r--r-- 808 bytes
webkit-text-fill-color-property-002.html -rw-r--r-- 1.1 KB
webkit-text-fill-color-property-003-ref.html -rw-r--r-- 853 bytes
webkit-text-fill-color-property-003.html -rw-r--r-- 1.1 KB
webkit-text-fill-color-property-004-ref.html -rw-r--r-- 690 bytes
webkit-text-fill-color-property-004.html -rw-r--r-- 966 bytes
webkit-text-fill-color-property-005-ref.html -rw-r--r-- 588 bytes
webkit-text-fill-color-property-005.html -rw-r--r-- 886 bytes
webkit-text-fill-color-property-006-ref.html -rw-r--r-- 605 bytes
webkit-text-fill-color-property-006.html -rw-r--r-- 897 bytes

back to top