Revision 4fc216649ddb40763963140eac3eb95890b32486 authored by Cheng Chang on 20 March 2020, 23:15:40 UTC, committed by Facebook GitHub Bot on 20 March 2020, 23:33:26 UTC
Summary:
By supporting direct IO in RandomAccessFileReader::MultiRead, the benefits of parallel IO (IO uring) and direct IO can be combined.

In direct IO mode, read requests are aligned and merged together before being issued to RandomAccessFile::MultiRead, so blocks in the original requests might share the same underlying buffer, the shared buffers are returned in `aligned_bufs`, which is a new parameter of the `MultiRead` API.

For example, suppose alignment requirement for direct IO is 4KB, one request is (offset: 1KB, len: 1KB), another request is (offset: 3KB, len: 1KB), then since they all belong to page (offset: 0, len: 4KB), `MultiRead` only reads the page with direct IO into a buffer on heap, and returns 2 Slices referencing regions in that same buffer. See `random_access_file_reader_test.cc` for more examples.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6446

Test Plan: Added a new test `random_access_file_reader_test.cc`.

Reviewed By: anand1976

Differential Revision: D20097518

Pulled By: cheng-chang

fbshipit-source-id: ca48a8faf9c3af146465c102ef6b266a363e78d1
1 parent 5fd152b
History
File Mode Size
amalgamate.py -rwxr-xr-x 4.7 KB
build_detect_platform -rwxr-xr-x 25.4 KB
dependencies.sh -rw-r--r-- 2.1 KB
dependencies_4.8.1.sh -rw-r--r-- 2.2 KB
dependencies_platform007.sh -rw-r--r-- 2.1 KB
dockerbuild.sh -rwxr-xr-x 148 bytes
error_filter.py -rw-r--r-- 6.6 KB
fb_compile_mongo.sh -rwxr-xr-x 1.5 KB
fbcode_config.sh -rw-r--r-- 4.7 KB
fbcode_config4.8.1.sh -rw-r--r-- 3.6 KB
fbcode_config_platform007.sh -rw-r--r-- 4.9 KB
format-diff.sh -rwxr-xr-x 4.7 KB
gnu_parallel -rwxr-xr-x 238.6 KB
make_package.sh -rwxr-xr-x 3.1 KB
precommit_checker.py -rwxr-xr-x 5.6 KB
regression_build_test.sh -rwxr-xr-x 11.3 KB
rocksdb-lego-determinator -rwxr-xr-x 27.8 KB
run_ci_db_test.ps1 -rw-r--r-- 14.5 KB
setup_centos7.sh -rwxr-xr-x 1.1 KB
update_dependencies.sh -rwxr-xr-x 5.4 KB
version.sh -rwxr-xr-x 769 bytes

back to top