Revision 52733b44984b67584121efb6730a9020cab3a67c authored by Maysam Yabandeh on 05 November 2019, 00:22:26 UTC, committed by Facebook Github Bot on 05 November 2019, 00:23:57 UTC
Summary: MaxCatchupWithNewSnapshot tests that the snapshot sequence number will be larger than the max sequence number when the snapshot was taken. However since the test does not have access to the max sequence number when the snapshot was taken, it uses max sequence number after that, which could have advanced the snapshot by then, thus making the test flaky. The fix is to compare with max sequence number before the snapshot was taken, which is a lower bound for the value when the snapshot was taken. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5850 Test Plan: ~/gtest-parallel/gtest-parallel --repeat=12800 ./write_prepared_transaction_test --gtest_filter="*MaxCatchupWithNewSnapshot*" Differential Revision: D17608926 Pulled By: maysamyabandeh fbshipit-source-id: b122ae5a27f982b290bd60da852e28d3c5eb0136
1 parent 0d91a98
| File | Mode | Size |
|---|---|---|
| block_cache_tracer.cc | -rw-r--r-- | 17.5 KB |
| block_cache_tracer.h | -rw-r--r-- | 11.0 KB |
| block_cache_tracer_test.cc | -rw-r--r-- | 15.3 KB |
| trace_replay.cc | -rw-r--r-- | 13.7 KB |
| trace_replay.h | -rw-r--r-- | 5.8 KB |
Computing file changes ...
