https://github.com/torvalds/linux
Revision 54b0d127696aba2ef1ec5430301c968ab539fa0d authored by Neil Brown on 07 January 2009, 07:55:39 UTC, committed by Jens Axboe on 09 January 2009, 20:46:13 UTC
Neil writes:
Hi Jens,
I've found a little bug for you. It was introduced by
a6f23657d3072bde6844055bbc2290e497f33fbc
block: add one-hit cache for disk partition lookup
and has the effect of killing my machine whenever I try to assemble
an md array :-(
One of the devices in the array has partitions, and mdadm always
deletes partitions before putting a whole-device in an array (as it
can cause confusion). The next IO to that device locks the machine.
I don't really understand exactly why it locks up, but it happens in
disk_map_sector_rcu(). This patch fixes it.
Which is due to a missing clear of the (now) stale partition lookup
data. So clear that when we delete a partition.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
1 parent 2150edc
Tip revision: 54b0d127696aba2ef1ec5430301c968ab539fa0d authored by Neil Brown on 07 January 2009, 07:55:39 UTC
block: fix bug in ptbl lookup cache
block: fix bug in ptbl lookup cache
Tip revision: 54b0d12
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 6.5 KB |
| Makefile | -rw-r--r-- | 1.3 KB |
| allocpercpu.c | -rw-r--r-- | 4.0 KB |
| backing-dev.c | -rw-r--r-- | 7.0 KB |
| bootmem.c | -rw-r--r-- | 17.8 KB |
| bounce.c | -rw-r--r-- | 6.5 KB |
| dmapool.c | -rw-r--r-- | 12.9 KB |
| fadvise.c | -rw-r--r-- | 2.9 KB |
| failslab.c | -rw-r--r-- | 1.3 KB |
| filemap.c | -rw-r--r-- | 64.8 KB |
| filemap_xip.c | -rw-r--r-- | 11.0 KB |
| fremap.c | -rw-r--r-- | 6.7 KB |
| highmem.c | -rw-r--r-- | 8.7 KB |
| hugetlb.c | -rw-r--r-- | 60.1 KB |
| internal.h | -rw-r--r-- | 7.9 KB |
| maccess.c | -rw-r--r-- | 1.4 KB |
| madvise.c | -rw-r--r-- | 9.5 KB |
| memcontrol.c | -rw-r--r-- | 55.6 KB |
| memory.c | -rw-r--r-- | 85.6 KB |
| memory_hotplug.c | -rw-r--r-- | 20.8 KB |
| mempolicy.c | -rw-r--r-- | 59.3 KB |
| mempool.c | -rw-r--r-- | 9.0 KB |
| migrate.c | -rw-r--r-- | 25.7 KB |
| mincore.c | -rw-r--r-- | 5.7 KB |
| mlock.c | -rw-r--r-- | 18.0 KB |
| mm_init.c | -rw-r--r-- | 3.7 KB |
| mmap.c | -rw-r--r-- | 64.4 KB |
| mmu_notifier.c | -rw-r--r-- | 8.2 KB |
| mmzone.c | -rw-r--r-- | 1.5 KB |
| mprotect.c | -rw-r--r-- | 7.5 KB |
| mremap.c | -rw-r--r-- | 11.1 KB |
| msync.c | -rw-r--r-- | 2.4 KB |
| nommu.c | -rw-r--r-- | 35.8 KB |
| oom_kill.c | -rw-r--r-- | 16.4 KB |
| page-writeback.c | -rw-r--r-- | 39.3 KB |
| page_alloc.c | -rw-r--r-- | 130.2 KB |
| page_cgroup.c | -rw-r--r-- | 10.5 KB |
| page_io.c | -rw-r--r-- | 3.4 KB |
| page_isolation.c | -rw-r--r-- | 3.6 KB |
| pagewalk.c | -rw-r--r-- | 3.2 KB |
| pdflush.c | -rw-r--r-- | 6.6 KB |
| prio_tree.c | -rw-r--r-- | 6.3 KB |
| quicklist.c | -rw-r--r-- | 2.4 KB |
| readahead.c | -rw-r--r-- | 13.4 KB |
| rmap.c | -rw-r--r-- | 34.2 KB |
| shmem.c | -rw-r--r-- | 67.9 KB |
| shmem_acl.c | -rw-r--r-- | 4.6 KB |
| slab.c | -rw-r--r-- | 115.1 KB |
| slob.c | -rw-r--r-- | 15.9 KB |
| slub.c | -rw-r--r-- | 105.9 KB |
| sparse-vmemmap.c | -rw-r--r-- | 4.2 KB |
| sparse.c | -rw-r--r-- | 16.2 KB |
| swap.c | -rw-r--r-- | 14.5 KB |
| swap_state.c | -rw-r--r-- | 10.1 KB |
| swapfile.c | -rw-r--r-- | 50.5 KB |
| thrash.c | -rw-r--r-- | 2.0 KB |
| truncate.c | -rw-r--r-- | 13.0 KB |
| util.c | -rw-r--r-- | 3.9 KB |
| vmalloc.c | -rw-r--r-- | 42.7 KB |
| vmscan.c | -rw-r--r-- | 72.6 KB |
| vmstat.c | -rw-r--r-- | 22.8 KB |
Computing file changes ...
