Revision 553febf4d8d473b7849eda2735ea77bbcb4f7c80 authored by Filip Roséen on 20 February 2016, 21:41:07 UTC, committed by Jean-Baptiste Kempf on 05 March 2016, 21:15:12 UTC
Manually managing memory comes at a cost of both maintainability (in
terms of safety) and performance, as such I have replaced `p_indexes`
with a `std::vector` with equivalent functionality.

Three helper member-functions have been introduced in order to clean up
the usage of the functionality, as well as removal of two now obsolete
member-variables. A `typedef` has also been introduced to aid future
development.

The changes in `mkv.cpp` are due to the fact that it needs access to the
indexes present in `matroska_segment_c`; this should be refactored away
in the future.

Also fixed a bug where you would access index out of bounds if there
are no known indexes.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
1 parent 881299b
History
File Mode Size
.gitignore -rw-r--r-- 74 bytes
Makefile.am -rw-r--r-- 519 bytes
c11.m4 -rw-r--r-- 1.2 KB
codeset.m4 -rw-r--r-- 832 bytes
dolt.m4 -rw-r--r-- 5.6 KB
extern-inline.m4 -rw-r--r-- 4.2 KB
fcntl-o.m4 -rw-r--r-- 4.6 KB
flags.m4 -rw-r--r-- 2.2 KB
gettext.m4 -rw-r--r-- 15.0 KB
glibc2.m4 -rw-r--r-- 830 bytes
glibc21.m4 -rw-r--r-- 907 bytes
iconv.m4 -rw-r--r-- 9.1 KB
intdiv0.m4 -rw-r--r-- 2.4 KB
intl.m4 -rw-r--r-- 11.8 KB
intldir.m4 -rw-r--r-- 923 bytes
intlmacosx.m4 -rw-r--r-- 2.5 KB
intmax.m4 -rw-r--r-- 1.1 KB
inttypes-pri.m4 -rw-r--r-- 1.2 KB
inttypes_h.m4 -rw-r--r-- 1020 bytes
lcmessage.m4 -rw-r--r-- 1.3 KB
lib-ld.m4 -rw-r--r-- 3.6 KB
lib-link.m4 -rw-r--r-- 32.3 KB
lib-prefix.m4 -rw-r--r-- 8.3 KB
lock.m4 -rw-r--r-- 1.4 KB
longlong.m4 -rw-r--r-- 4.6 KB
nls.m4 -rw-r--r-- 1.2 KB
po.m4 -rw-r--r-- 18.5 KB
printf-posix.m4 -rw-r--r-- 1.5 KB
progtest.m4 -rw-r--r-- 3.0 KB
size_max.m4 -rw-r--r-- 3.0 KB
stdcxx_11.m4 -rw-r--r-- 5.3 KB
stdint_h.m4 -rw-r--r-- 995 bytes
threadlib.m4 -rw-r--r-- 14.8 KB
uintmax_t.m4 -rw-r--r-- 1.1 KB
visibility.m4 -rw-r--r-- 3.3 KB
vlc.m4 -rw-r--r-- 3.0 KB
wchar_t.m4 -rw-r--r-- 818 bytes
wint_t.m4 -rw-r--r-- 1.0 KB
with_pkg.m4 -rw-r--r-- 3.8 KB
xsize.m4 -rw-r--r-- 406 bytes

back to top