Revision 5a61e7864d04e7e72b62749ca07bdb94af85ca87 authored by Yanqin Jin on 05 May 2020, 00:43:33 UTC, committed by Facebook GitHub Bot on 05 May 2020, 00:45:49 UTC
Summary:
Current impl. of db_stress will abort verification and report failure if
GetLiveFiles() causes a dropped column family to be flushed. This is not
desired.
To fix, this PR makes the following change:
In GetLiveFiles, if flush is triggered and returns
Status::IsColumnFamilyDropped(), then set status to Status::OK().
This is OK because dropped column families will be skipped during the rest of
this function, and valid column families will have their live files returned to
caller.

Test plan (dev server):
make check
./db_stress -ops_per_thread=1000 -get_live_files_one_in=100 -clear_column_family_one_in=100
./db_stress -disable_wal=1 -reopen=0 -ops_per_thread=1000 -get_live_files_one_in=100 -clear_column_family_one_in=100
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6805

Reviewed By: ltamasi

Differential Revision: D21390044

Pulled By: riversand963

fbshipit-source-id: de67846b95a4f1b88aa0a30c3d70c43cc68625b9
1 parent a00ddf1
History
File Mode Size
win
README -rw-r--r-- 405 bytes
jemalloc_helper.h -rw-r--r-- 3.5 KB
lang.h -rw-r--r-- 536 bytes
likely.h -rw-r--r-- 690 bytes
malloc.h -rw-r--r-- 656 bytes
port.h -rw-r--r-- 834 bytes
port_dirent.h -rw-r--r-- 1.0 KB
port_example.h -rw-r--r-- 3.5 KB
port_posix.cc -rw-r--r-- 7.1 KB
port_posix.h -rw-r--r-- 6.0 KB
stack_trace.cc -rw-r--r-- 4.3 KB
stack_trace.h -rw-r--r-- 891 bytes
sys_time.h -rw-r--r-- 1.2 KB
util_logger.h -rw-r--r-- 823 bytes
xpress.h -rw-r--r-- 687 bytes

README

back to top