Skip to main content

Browse the archive

https://github.com/Kitware/CMake
10 April 2024, 19:27:19 UTC
Revision 5a95b5e091fa2a2d0ad869a80c37eaa980917853 authored by Brad King on 30 March 2020, 15:08:10 UTC, committed by Brad King on 30 March 2020, 15:24:27 UTC 
target_link_libraries: Fix regression in case of $<CONFIG> genex
 
Since commit b8626261e9 (Precompile headers: Add methods to generate PCH
sources, 2019-07-13, v3.16.0-rc1~182^2~4) we look up source files for a
target using an upper-case configuration even though an original-case
name is sufficient.  Since commit 36ded610af (PCH: Generate sources
during Compute step, 2019-10-05, v3.16.0-rc1~2^2) the source file lookup
is the first time we compute many on-demand structures that depend on
the configuration name.  This caused the `$<CONFIG>` generator
expression to evaluate to the upper-case configuration name in some
cases where we used original-case before.

Fix this by switching the source file lookup to the original-case config
name.  Add a test covering the symptom that led to the discovery of this
problem.

Fixes: #20517
1 parent b7d8c91
Raw File
Tip revision: 5a95b5e091fa2a2d0ad869a80c37eaa980917853 authored by Brad King on 30 March 2020, 15:08:10 UTC
target_link_libraries: Fix regression in case of $<CONFIG> genex
Tip revision: 5a95b5e
.gitattributes 
.git*            export-ignore
.hooks*          export-ignore

# Custom attribute to mark sources as using our C code style.
[attr]our-c-style  whitespace=tab-in-indent  format.clang-format-6.0

# Custom attribute to mark sources as generated.
# Do not perform whitespace checks.  Do not format.
[attr]generated  whitespace=-tab-in-indent,-indent-with-non-tab -format.clang-format-6.0

bootstrap        eol=lf
configure        eol=lf
*.[1-9]          eol=lf
*.bash           eol=lf
*.sh             eol=lf
*.sh.in          eol=lf

*.bat            eol=crlf
*.bat.in         eol=crlf
*.sln            eol=crlf
*.vcproj         eol=crlf

*.pfx            -text
*.png            -text
*.png.in         -text

*.c              our-c-style
*.cc             our-c-style
*.cpp            our-c-style
*.cu             our-c-style
*.cxx            our-c-style
*.h              our-c-style
*.hh             our-c-style
*.hpp            our-c-style
*.hxx            our-c-style
*.notcu          our-c-style

*.cmake          whitespace=tab-in-indent
*.rst            whitespace=tab-in-indent conflict-marker-size=79
*.txt            whitespace=tab-in-indent
back to top