Revision 5ae2efb1dea9f537453e841714e3ee2757595aec authored by Oscar Salvador on 29 March 2019, 03:44:01 UTC, committed by Linus Torvalds on 29 March 2019, 17:01:37 UTC
While debugging something, I added a dump_page() into do_swap_page(), and I got the splat from below. The issue happens when dereferencing mapping->host in __dump_page(): ... else if (mapping) { pr_warn("%ps ", mapping->a_ops); if (mapping->host->i_dentry.first) { struct dentry *dentry; dentry = container_of(mapping->host->i_dentry.first, struct dentry, d_u.d_alias); pr_warn("name:\"%pd\" ", dentry); } } ... Swap address space does not contain an inode information, and so mapping->host equals NULL. Although the dump_page() call was added artificially into do_swap_page(), I am not sure if we can hit this from any other path, so it looks worth fixing it. We can easily do that by checking mapping->host first. Link: http://lkml.kernel.org/r/20190318072931.29094-1-osalvador@suse.de Fixes: 1c6fb1d89e73c ("mm: print more information about mapping in __dump_page") Signed-off-by: Oscar Salvador <osalvador@suse.de> Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: Hugh Dickins <hughd@google.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent a7f40cf
File | Mode | Size |
---|---|---|
.gitignore | -rw-r--r-- | 44 bytes |
Kconfig | -rw-r--r-- | 3.4 KB |
Makefile | -rw-r--r-- | 4.1 KB |
blacklist.c | -rw-r--r-- | 4.0 KB |
blacklist.h | -rw-r--r-- | 84 bytes |
blacklist_hashes.c | -rw-r--r-- | 166 bytes |
blacklist_nohashes.c | -rw-r--r-- | 122 bytes |
system_certificates.S | -rw-r--r-- | 828 bytes |
system_keyring.c | -rw-r--r-- | 8.0 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...