https://github.com/torvalds/linux
Revision 5f32b265400de723ab0db23101a75ac073bdd980 authored by Jérôme Glisse on 31 August 2017, 21:17:38 UTC, committed by Linus Torvalds on 31 August 2017, 23:13:00 UTC
The invalidate_page callback suffered from two pitfalls. First it used to happen after the page table lock was release and thus a new page might have setup before the call to invalidate_page() happened. This is in a weird way fixed by commit c7ab0d2fdc84 ("mm: convert try_to_unmap_one() to use page_vma_mapped_walk()") that moved the callback under the page table lock but this also broke several existing users of the mmu_notifier API that assumed they could sleep inside this callback. The second pitfall was invalidate_page() being the only callback not taking a range of address in respect to invalidation but was giving an address and a page. Lots of the callback implementers assumed this could never be THP and thus failed to invalidate the appropriate range for THP. By killing this callback we unify the mmu_notifier callback API to always take a virtual address range as input. Finally this also simplifies the end user life as there is now two clear choices: - invalidate_range_start()/end() callback (which allow you to sleep) - invalidate_range() where you can not sleep but happen right after page table update under page table lock Signed-off-by: Jérôme Glisse <jglisse@redhat.com> Cc: Bernhard Held <berny156@gmx.de> Cc: Adam Borowski <kilobyte@angband.pl> Cc: Andrea Arcangeli <aarcange@redhat.com> Cc: Radim Krčmář <rkrcmar@redhat.com> Cc: Wanpeng Li <kernellwp@gmail.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Takashi Iwai <tiwai@suse.de> Cc: Nadav Amit <nadav.amit@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: axie <axie@amd.com> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent fb1522e
Tip revision: 5f32b265400de723ab0db23101a75ac073bdd980 authored by Jérôme Glisse on 31 August 2017, 21:17:38 UTC
mm/mmu_notifier: kill invalidate_page
mm/mmu_notifier: kill invalidate_page
Tip revision: 5f32b26
File | Mode | Size |
---|---|---|
kasan | ||
Kconfig | -rw-r--r-- | 23.4 KB |
Kconfig.debug | -rw-r--r-- | 3.8 KB |
Makefile | -rw-r--r-- | 3.6 KB |
backing-dev.c | -rw-r--r-- | 27.5 KB |
balloon_compaction.c | -rw-r--r-- | 4.7 KB |
bootmem.c | -rw-r--r-- | 20.8 KB |
cleancache.c | -rw-r--r-- | 9.9 KB |
cma.c | -rw-r--r-- | 13.5 KB |
cma.h | -rw-r--r-- | 534 bytes |
cma_debug.c | -rw-r--r-- | 4.5 KB |
compaction.c | -rw-r--r-- | 57.9 KB |
debug.c | -rw-r--r-- | 4.2 KB |
debug_page_ref.c | -rw-r--r-- | 1.3 KB |
dmapool.c | -rw-r--r-- | 13.7 KB |
early_ioremap.c | -rw-r--r-- | 6.2 KB |
fadvise.c | -rw-r--r-- | 4.3 KB |
failslab.c | -rw-r--r-- | 1.4 KB |
filemap.c | -rw-r--r-- | 84.7 KB |
frame_vector.c | -rw-r--r-- | 6.0 KB |
frontswap.c | -rw-r--r-- | 14.3 KB |
gup.c | -rw-r--r-- | 47.4 KB |
highmem.c | -rw-r--r-- | 11.7 KB |
huge_memory.c | -rw-r--r-- | 74.9 KB |
hugetlb.c | -rw-r--r-- | 126.7 KB |
hugetlb_cgroup.c | -rw-r--r-- | 10.9 KB |
hwpoison-inject.c | -rw-r--r-- | 3.2 KB |
init-mm.c | -rw-r--r-- | 680 bytes |
internal.h | -rw-r--r-- | 16.3 KB |
interval_tree.c | -rw-r--r-- | 3.1 KB |
khugepaged.c | -rw-r--r-- | 48.5 KB |
kmemcheck.c | -rw-r--r-- | 2.9 KB |
kmemleak-test.c | -rw-r--r-- | 3.2 KB |
kmemleak.c | -rw-r--r-- | 58.7 KB |
ksm.c | -rw-r--r-- | 85.5 KB |
list_lru.c | -rw-r--r-- | 12.6 KB |
maccess.c | -rw-r--r-- | 3.0 KB |
madvise.c | -rw-r--r-- | 21.6 KB |
memblock.c | -rw-r--r-- | 50.5 KB |
memcontrol.c | -rw-r--r-- | 156.9 KB |
memory-failure.c | -rw-r--r-- | 47.8 KB |
memory.c | -rw-r--r-- | 118.8 KB |
memory_hotplug.c | -rw-r--r-- | 50.1 KB |
mempolicy.c | -rw-r--r-- | 68.2 KB |
mempool.c | -rw-r--r-- | 13.9 KB |
memtest.c | -rw-r--r-- | 2.7 KB |
migrate.c | -rw-r--r-- | 51.5 KB |
mincore.c | -rw-r--r-- | 6.7 KB |
mlock.c | -rw-r--r-- | 22.6 KB |
mm_init.c | -rw-r--r-- | 4.8 KB |
mmap.c | -rw-r--r-- | 96.2 KB |
mmu_context.c | -rw-r--r-- | 1.3 KB |
mmu_notifier.c | -rw-r--r-- | 11.2 KB |
mmzone.c | -rw-r--r-- | 2.4 KB |
mprotect.c | -rw-r--r-- | 13.5 KB |
mremap.c | -rw-r--r-- | 16.4 KB |
msync.c | -rw-r--r-- | 2.6 KB |
nobootmem.c | -rw-r--r-- | 10.6 KB |
nommu.c | -rw-r--r-- | 48.6 KB |
oom_kill.c | -rw-r--r-- | 28.8 KB |
page-writeback.c | -rw-r--r-- | 84.6 KB |
page_alloc.c | -rw-r--r-- | 213.3 KB |
page_counter.c | -rw-r--r-- | 4.8 KB |
page_ext.c | -rw-r--r-- | 11.1 KB |
page_idle.c | -rw-r--r-- | 5.4 KB |
page_io.c | -rw-r--r-- | 10.1 KB |
page_isolation.c | -rw-r--r-- | 8.0 KB |
page_owner.c | -rw-r--r-- | 14.8 KB |
page_poison.c | -rw-r--r-- | 2.6 KB |
page_vma_mapped.c | -rw-r--r-- | 5.8 KB |
pagewalk.c | -rw-r--r-- | 8.4 KB |
percpu-internal.h | -rw-r--r-- | 4.1 KB |
percpu-km.c | -rw-r--r-- | 2.9 KB |
percpu-stats.c | -rw-r--r-- | 5.0 KB |
percpu-vm.c | -rw-r--r-- | 10.1 KB |
percpu.c | -rw-r--r-- | 66.8 KB |
pgtable-generic.c | -rw-r--r-- | 5.2 KB |
process_vm_access.c | -rw-r--r-- | 10.1 KB |
quicklist.c | -rw-r--r-- | 2.4 KB |
readahead.c | -rw-r--r-- | 16.1 KB |
rmap.c | -rw-r--r-- | 49.9 KB |
rodata_test.c | -rw-r--r-- | 1.4 KB |
shmem.c | -rw-r--r-- | 110.6 KB |
slab.c | -rw-r--r-- | 110.2 KB |
slab.h | -rw-r--r-- | 14.4 KB |
slab_common.c | -rw-r--r-- | 34.3 KB |
slob.c | -rw-r--r-- | 16.0 KB |
slub.c | -rw-r--r-- | 140.6 KB |
sparse-vmemmap.c | -rw-r--r-- | 8.2 KB |
sparse.c | -rw-r--r-- | 22.8 KB |
swap.c | -rw-r--r-- | 27.1 KB |
swap_cgroup.c | -rw-r--r-- | 5.2 KB |
swap_slots.c | -rw-r--r-- | 9.1 KB |
swap_state.c | -rw-r--r-- | 14.8 KB |
swapfile.c | -rw-r--r-- | 88.2 KB |
truncate.c | -rw-r--r-- | 25.4 KB |
usercopy.c | -rw-r--r-- | 7.5 KB |
userfaultfd.c | -rw-r--r-- | 14.3 KB |
util.c | -rw-r--r-- | 18.4 KB |
vmacache.c | -rw-r--r-- | 3.2 KB |
vmalloc.c | -rw-r--r-- | 70.4 KB |
vmpressure.c | -rw-r--r-- | 14.3 KB |
vmscan.c | -rw-r--r-- | 115.1 KB |
vmstat.c | -rw-r--r-- | 47.5 KB |
workingset.c | -rw-r--r-- | 18.2 KB |
z3fold.c | -rw-r--r-- | 23.8 KB |
zbud.c | -rw-r--r-- | 18.2 KB |
zpool.c | -rw-r--r-- | 10.0 KB |
zsmalloc.c | -rw-r--r-- | 58.9 KB |
zswap.c | -rw-r--r-- | 32.8 KB |
Computing file changes ...