Revision 645efa84f6c7566ea863ed37a8b3247247f72e02 authored by Mikulas Patocka on 05 February 2019, 10:09:00 UTC, committed by Mike Snitzer on 06 February 2019, 22:24:37 UTC
Block core changes to switch bio-based IO accounting to be percpu had a
side-effect of altering DM core to now rely on calling waitqueue_active
(in both bio-based and request-based) to check if another task is in
dm_wait_for_completion().
A memory barrier is needed before calling waitqueue_active(). DM core
doesn't piggyback on a preceding memory barrier so it must explicitly
use its own.
For more details on why using waitqueue_active() without a preceding
barrier is unsafe, please see the comment before the waitqueue_active()
definition in include/linux/wait.h.
Add the missing memory barrier by switching to using wq_has_sleeper().
Fixes: 6f75723190d8 ("dm: remove the pending IO accounting")
Fixes: c4576aed8d85 ("dm: fix request-based dm's use of dm_wait_for_completion")
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
1 parent 8834f56
| File | Mode | Size |
|---|---|---|
| asymmetric_keys | ||
| async_tx | ||
| 842.c | -rw-r--r-- | 4.2 KB |
| Kconfig | -rw-r--r-- | 54.4 KB |
| Makefile | -rw-r--r-- | 6.1 KB |
| ablkcipher.c | -rw-r--r-- | 10.6 KB |
| acompress.c | -rw-r--r-- | 4.7 KB |
| adiantum.c | -rw-r--r-- | 20.8 KB |
| aead.c | -rw-r--r-- | 10.2 KB |
| aegis.h | -rw-r--r-- | 2.2 KB |
| aegis128.c | -rw-r--r-- | 11.7 KB |
| aegis128l.c | -rw-r--r-- | 14.3 KB |
| aegis256.c | -rw-r--r-- | 12.4 KB |
| aes_generic.c | -rw-r--r-- | 62.2 KB |
| aes_ti.c | -rw-r--r-- | 12.7 KB |
| af_alg.c | -rw-r--r-- | 26.0 KB |
| ahash.c | -rw-r--r-- | 16.3 KB |
| akcipher.c | -rw-r--r-- | 3.9 KB |
| algapi.c | -rw-r--r-- | 29.3 KB |
| algboss.c | -rw-r--r-- | 6.0 KB |
| algif_aead.c | -rw-r--r-- | 16.0 KB |
| algif_hash.c | -rw-r--r-- | 9.8 KB |
| algif_rng.c | -rw-r--r-- | 5.2 KB |
| algif_skcipher.c | -rw-r--r-- | 10.1 KB |
| ansi_cprng.c | -rw-r--r-- | 10.9 KB |
| anubis.c | -rw-r--r-- | 27.8 KB |
| api.c | -rw-r--r-- | 13.9 KB |
| arc4.c | -rw-r--r-- | 3.4 KB |
| authenc.c | -rw-r--r-- | 14.2 KB |
| authencesn.c | -rw-r--r-- | 15.3 KB |
| blkcipher.c | -rw-r--r-- | 14.9 KB |
| blowfish_common.c | -rw-r--r-- | 15.7 KB |
| blowfish_generic.c | -rw-r--r-- | 3.4 KB |
| camellia_generic.c | -rw-r--r-- | 34.9 KB |
| cast5_generic.c | -rw-r--r-- | 20.8 KB |
| cast6_generic.c | -rw-r--r-- | 9.4 KB |
| cast_common.c | -rw-r--r-- | 13.1 KB |
| cbc.c | -rw-r--r-- | 5.1 KB |
| ccm.c | -rw-r--r-- | 25.6 KB |
| cfb.c | -rw-r--r-- | 8.7 KB |
| chacha20poly1305.c | -rw-r--r-- | 19.4 KB |
| chacha_generic.c | -rw-r--r-- | 6.0 KB |
| cipher.c | -rw-r--r-- | 3.3 KB |
| cmac.c | -rw-r--r-- | 7.7 KB |
| compress.c | -rw-r--r-- | 1.3 KB |
| crc32_generic.c | -rw-r--r-- | 3.7 KB |
| crc32c_generic.c | -rw-r--r-- | 4.4 KB |
| crct10dif_common.c | -rw-r--r-- | 3.6 KB |
| crct10dif_generic.c | -rw-r--r-- | 3.2 KB |
| cryptd.c | -rw-r--r-- | 36.5 KB |
| crypto_engine.c | -rw-r--r-- | 13.5 KB |
| crypto_null.c | -rw-r--r-- | 5.3 KB |
| crypto_user_base.c | -rw-r--r-- | 12.1 KB |
| crypto_user_stat.c | -rw-r--r-- | 9.7 KB |
| crypto_wq.c | -rw-r--r-- | 972 bytes |
| ctr.c | -rw-r--r-- | 12.6 KB |
| cts.c | -rw-r--r-- | 12.0 KB |
| deflate.c | -rw-r--r-- | 7.9 KB |
| des_generic.c | -rw-r--r-- | 35.7 KB |
| dh.c | -rw-r--r-- | 4.9 KB |
| dh_helper.c | -rw-r--r-- | 3.6 KB |
| drbg.c | -rw-r--r-- | 57.2 KB |
| ecb.c | -rw-r--r-- | 4.9 KB |
| ecc.c | -rw-r--r-- | 27.6 KB |
| ecc.h | -rw-r--r-- | 3.7 KB |
| ecc_curve_defs.h | -rw-r--r-- | 2.1 KB |
| ecdh.c | -rw-r--r-- | 4.1 KB |
| ecdh_helper.c | -rw-r--r-- | 2.3 KB |
| echainiv.c | -rw-r--r-- | 4.5 KB |
| fcrypt.c | -rw-r--r-- | 18.0 KB |
| fips.c | -rw-r--r-- | 1.6 KB |
| gcm.c | -rw-r--r-- | 32.9 KB |
| gf128mul.c | -rw-r--r-- | 12.4 KB |
| ghash-generic.c | -rw-r--r-- | 3.5 KB |
| hash_info.c | -rw-r--r-- | 2.1 KB |
| hmac.c | -rw-r--r-- | 6.9 KB |
| internal.h | -rw-r--r-- | 3.7 KB |
| jitterentropy-kcapi.c | -rw-r--r-- | 6.0 KB |
| jitterentropy.c | -rw-r--r-- | 23.9 KB |
| keywrap.c | -rw-r--r-- | 11.4 KB |
| khazad.c | -rw-r--r-- | 51.8 KB |
| kpp.c | -rw-r--r-- | 2.9 KB |
| lrw.c | -rw-r--r-- | 10.8 KB |
| lz4.c | -rw-r--r-- | 3.9 KB |
| lz4hc.c | -rw-r--r-- | 4.0 KB |
| lzo.c | -rw-r--r-- | 3.9 KB |
| md4.c | -rw-r--r-- | 5.9 KB |
| md5.c | -rw-r--r-- | 7.4 KB |
| memneq.c | -rw-r--r-- | 6.1 KB |
| michael_mic.c | -rw-r--r-- | 3.6 KB |
| morus1280.c | -rw-r--r-- | 14.1 KB |
| morus640.c | -rw-r--r-- | 13.7 KB |
| nhpoly1305.c | -rw-r--r-- | 7.7 KB |
| ofb.c | -rw-r--r-- | 5.3 KB |
| pcbc.c | -rw-r--r-- | 7.8 KB |
| pcrypt.c | -rw-r--r-- | 13.2 KB |
| poly1305_generic.c | -rw-r--r-- | 8.5 KB |
| proc.c | -rw-r--r-- | 2.7 KB |
| ripemd.h | -rw-r--r-- | 1013 bytes |
| rmd128.c | -rw-r--r-- | 10.2 KB |
| rmd160.c | -rw-r--r-- | 12.6 KB |
| rmd256.c | -rw-r--r-- | 10.5 KB |
| rmd320.c | -rw-r--r-- | 13.0 KB |
| rng.c | -rw-r--r-- | 4.9 KB |
| rsa-pkcs1pad.c | -rw-r--r-- | 17.6 KB |
| rsa.c | -rw-r--r-- | 7.5 KB |
| rsa_helper.c | -rw-r--r-- | 4.2 KB |
| rsaprivkey.asn1 | -rw-r--r-- | 316 bytes |
| rsapubkey.asn1 | -rw-r--r-- | 82 bytes |
| salsa20_generic.c | -rw-r--r-- | 6.0 KB |
| scatterwalk.c | -rw-r--r-- | 2.2 KB |
| scompress.c | -rw-r--r-- | 7.4 KB |
| seed.c | -rw-r--r-- | 17.4 KB |
| seqiv.c | -rw-r--r-- | 5.3 KB |
| serpent_generic.c | -rw-r--r-- | 21.4 KB |
| sha1_generic.c | -rw-r--r-- | 2.6 KB |
| sha256_generic.c | -rw-r--r-- | 11.0 KB |
| sha3_generic.c | -rw-r--r-- | 8.2 KB |
| sha512_generic.c | -rw-r--r-- | 8.0 KB |
| shash.c | -rw-r--r-- | 14.6 KB |
| simd.c | -rw-r--r-- | 7.3 KB |
| skcipher.c | -rw-r--r-- | 27.0 KB |
| sm3_generic.c | -rw-r--r-- | 4.6 KB |
| sm4_generic.c | -rw-r--r-- | 6.3 KB |
| streebog_generic.c | -rw-r--r-- | 59.4 KB |
| tcrypt.c | -rw-r--r-- | 78.5 KB |
| tcrypt.h | -rw-r--r-- | 4.4 KB |
| tea.c | -rw-r--r-- | 6.6 KB |
| testmgr.c | -rw-r--r-- | 85.8 KB |
| testmgr.h | -rw-r--r-- | 1.2 MB |
| tgr192.c | -rw-r--r-- | 30.4 KB |
| twofish_common.c | -rw-r--r-- | 37.8 KB |
| twofish_generic.c | -rw-r--r-- | 6.2 KB |
| vmac.c | -rw-r--r-- | 18.8 KB |
| wp512.c | -rw-r--r-- | 59.7 KB |
| xcbc.c | -rw-r--r-- | 7.2 KB |
| xor.c | -rw-r--r-- | 3.8 KB |
| xts.c | -rw-r--r-- | 9.0 KB |
| zstd.c | -rw-r--r-- | 5.3 KB |
Computing file changes ...
