Revision 67beb600563cf28186f44450e528df1ec4d524fd authored by Jeff King on 28 January 2014, 01:37:30 UTC, committed by Junio C Hamano on 28 January 2014, 19:59:49 UTC
When we see config like:

  [include]
  path

the expand_user_path helper notices that the config value is
empty, but we then dereference NULL while printing the error
message (glibc will helpfully print "(null)" for us here,
but we cannot rely on that).

  $ git -c include.path rev-parse
  error: Could not expand include path '(null)'
  fatal: unable to parse command-line config

Instead of tweaking our message, let's actually use
config_error_nonbool to match other config variables that
expect a value:

  $ git -c include.path rev-parse
  error: Missing value for 'include.path'
  fatal: unable to parse command-line config

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 53ec551
History
File Mode Size
araxis -rw-r--r-- 392 bytes
bc3 -rw-r--r-- 401 bytes
defaults -rw-r--r-- 695 bytes
deltawalker -rw-r--r-- 628 bytes
diffuse -rw-r--r-- 282 bytes
ecmerge -rw-r--r-- 340 bytes
emerge -rw-r--r-- 415 bytes
kdiff3 -rw-r--r-- 506 bytes
kompare -rw-r--r-- 83 bytes
meld -rw-r--r-- 680 bytes
opendiff -rw-r--r-- 301 bytes
p4merge -rw-r--r-- 191 bytes
tkdiff -rw-r--r-- 224 bytes
tortoisemerge -rw-r--r-- 279 bytes
vim -rw-r--r-- 785 bytes
xxdiff -rw-r--r-- 618 bytes

back to top