Revision 6c50fe1ec9eb35f69d3b4d38cc7475a83113932e authored by sdong on 20 March 2020, 21:42:47 UTC, committed by Facebook GitHub Bot on 20 March 2020, 21:59:54 UTC
Summary:
When building RocksDB on VS2015, an error shows up with

hash_map.h(39): error C2719: 'value': formal parameter with requested alignment of 8 won't be aligned

Making the reference a reference can solve the problem, and there isn't a reason we can't do that, at least for the current use of the hash map.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6567

Test Plan: See CI tests pass.

Reviewed By: pdillinger

Differential Revision: D20548543

fbshipit-source-id: 255b55d74cf68a0b324e6f504c56608a97ea6276
1 parent 66cd07c
History
File Mode Size
CMakeLists.txt -rw-r--r-- 395 bytes
batched_ops_stress.cc -rw-r--r-- 13.0 KB
cf_consistency_stress.cc -rw-r--r-- 21.2 KB
db_stress.cc -rw-r--r-- 763 bytes
db_stress_common.cc -rw-r--r-- 8.5 KB
db_stress_common.h -rw-r--r-- 17.8 KB
db_stress_driver.cc -rw-r--r-- 4.8 KB
db_stress_driver.h -rw-r--r-- 727 bytes
db_stress_env_wrapper.h -rw-r--r-- 1.3 KB
db_stress_gflags.cc -rw-r--r-- 28.7 KB
db_stress_listener.h -rw-r--r-- 6.5 KB
db_stress_shared_state.cc -rw-r--r-- 752 bytes
db_stress_shared_state.h -rw-r--r-- 12.9 KB
db_stress_stat.h -rw-r--r-- 6.2 KB
db_stress_test_base.cc -rw-r--r-- 78.5 KB
db_stress_test_base.h -rw-r--r-- 8.8 KB
db_stress_tool.cc -rw-r--r-- 9.2 KB
no_batched_ops_stress.cc -rw-r--r-- 22.1 KB

back to top