Revision 6c50fe1ec9eb35f69d3b4d38cc7475a83113932e authored by sdong on 20 March 2020, 21:42:47 UTC, committed by Facebook GitHub Bot on 20 March 2020, 21:59:54 UTC
Summary: When building RocksDB on VS2015, an error shows up with hash_map.h(39): error C2719: 'value': formal parameter with requested alignment of 8 won't be aligned Making the reference a reference can solve the problem, and there isn't a reason we can't do that, at least for the current use of the hash map. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6567 Test Plan: See CI tests pass. Reviewed By: pdillinger Differential Revision: D20548543 fbshipit-source-id: 255b55d74cf68a0b324e6f504c56608a97ea6276
1 parent 66cd07c
| File | Mode | Size |
|---|---|---|
| composite_env_wrapper.h | -rw-r--r-- | 40.2 KB |
| env.cc | -rw-r--r-- | 13.1 KB |
| env_basic_test.cc | -rw-r--r-- | 12.6 KB |
| env_chroot.cc | -rw-r--r-- | 12.6 KB |
| env_chroot.h | -rw-r--r-- | 704 bytes |
| env_encryption.cc | -rw-r--r-- | 34.0 KB |
| env_hdfs.cc | -rw-r--r-- | 19.3 KB |
| env_posix.cc | -rw-r--r-- | 15.9 KB |
| env_test.cc | -rw-r--r-- | 61.9 KB |
| file_system.cc | -rw-r--r-- | 3.4 KB |
| fs_posix.cc | -rw-r--r-- | 30.4 KB |
| io_posix.cc | -rw-r--r-- | 44.2 KB |
| io_posix.h | -rw-r--r-- | 13.9 KB |
| io_posix_test.cc | -rw-r--r-- | 4.1 KB |
| mock_env.cc | -rw-r--r-- | 20.7 KB |
| mock_env.h | -rw-r--r-- | 4.0 KB |
| mock_env_test.cc | -rw-r--r-- | 2.7 KB |
Computing file changes ...
