Revision 6c50fe1ec9eb35f69d3b4d38cc7475a83113932e authored by sdong on 20 March 2020, 21:42:47 UTC, committed by Facebook GitHub Bot on 20 March 2020, 21:59:54 UTC
Summary:
When building RocksDB on VS2015, an error shows up with

hash_map.h(39): error C2719: 'value': formal parameter with requested alignment of 8 won't be aligned

Making the reference a reference can solve the problem, and there isn't a reason we can't do that, at least for the current use of the hash map.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6567

Test Plan: See CI tests pass.

Reviewed By: pdillinger

Differential Revision: D20548543

fbshipit-source-id: 255b55d74cf68a0b324e6f504c56608a97ea6276
1 parent 66cd07c
History
File Mode Size
benchmark
crossbuild
jmh
rocksjni
samples
src
CMakeLists.txt -rw-r--r-- 20.7 KB
HISTORY-JAVA.md -rw-r--r-- 3.2 KB
Makefile -rw-r--r-- 12.0 KB
RELEASE.md -rw-r--r-- 2.5 KB
jdb_bench.sh -rwxr-xr-x 460 bytes
rocksjni.pom -rw-r--r-- 6.3 KB

back to top