Revision 6c50fe1ec9eb35f69d3b4d38cc7475a83113932e authored by sdong on 20 March 2020, 21:42:47 UTC, committed by Facebook GitHub Bot on 20 March 2020, 21:59:54 UTC
Summary: When building RocksDB on VS2015, an error shows up with hash_map.h(39): error C2719: 'value': formal parameter with requested alignment of 8 won't be aligned Making the reference a reference can solve the problem, and there isn't a reason we can't do that, at least for the current use of the hash map. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6567 Test Plan: See CI tests pass. Reviewed By: pdillinger Differential Revision: D20548543 fbshipit-source-id: 255b55d74cf68a0b324e6f504c56608a97ea6276
1 parent 66cd07c
| File | Mode | Size |
|---|---|---|
| alloc_tracker.cc | -rw-r--r-- | 2.0 KB |
| hash_linklist_rep.cc | -rw-r--r-- | 28.8 KB |
| hash_linklist_rep.h | -rw-r--r-- | 1.9 KB |
| hash_skiplist_rep.cc | -rw-r--r-- | 10.9 KB |
| hash_skiplist_rep.h | -rw-r--r-- | 1.5 KB |
| inlineskiplist.h | -rw-r--r-- | 35.2 KB |
| inlineskiplist_test.cc | -rw-r--r-- | 17.8 KB |
| memtablerep_bench.cc | -rw-r--r-- | 23.7 KB |
| skiplist.h | -rw-r--r-- | 15.7 KB |
| skiplist_test.cc | -rw-r--r-- | 10.2 KB |
| skiplistrep.cc | -rw-r--r-- | 8.9 KB |
| stl_wrappers.h | -rw-r--r-- | 898 bytes |
| vectorrep.cc | -rw-r--r-- | 8.8 KB |
| write_buffer_manager.cc | -rw-r--r-- | 4.8 KB |
| write_buffer_manager_test.cc | -rw-r--r-- | 5.4 KB |
Computing file changes ...
