Revision 6c67c7c38cf32c2a9cbccb6b21aadf61a85fbfb4 authored by David Howells on 21 May 2014, 13:48:05 UTC, committed by David Howells on 21 May 2014, 13:48:05 UTC
Fix the cache manager RPC service handlers. The afs_send_empty_reply() and afs_send_simple_reply() functions: (a) Kill the call and free up the buffers associated with it if they fail. (b) Return with call intact if it they succeed. However, none of the callers actually check the result or clean up if successful - and may use the now non-existent data if it fails. This was detected by Dan Carpenter using a static checker: The patch 08e0e7c82eea: "[AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC." from Apr 26, 2007, leads to the following static checker warning: "fs/afs/cmservice.c:155 SRXAFSCB_CallBack() warn: 'call' was already freed." Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David Howells <dhowells@redhat.com>
1 parent 60b5f90
| File | Mode | Size |
|---|---|---|
| .gitignore | -rw-r--r-- | 151 bytes |
| Kconfig | -rw-r--r-- | 5.6 KB |
| Makefile | -rw-r--r-- | 2.3 KB |
| gen_init_cpio.c | -rw-r--r-- | 12.7 KB |
| initramfs_data.S | -rw-r--r-- | 1.3 KB |
Computing file changes ...
