Revision 6cf11ee6300f38b7cfc43af9b7be2afaa5e05869 authored by Hans Verkuil on 19 January 2015, 09:16:18 UTC, committed by Mauro Carvalho Chehab on 21 January 2015, 23:07:26 UTC
The locking scheme inside the vb2 thread is unsafe when stopping the thread. In particular kthread_stop was called *after* internal data structures were cleaned up instead of doing that before. In addition, internal vb2 functions were called after threadio->stop was set to true and vb2_internal_streamoff was called. This is also not allowed. All this led to a variety of race conditions and kernel warnings and/or oopses. Fixed by moving the kthread_stop call up before the cleanup takes place, and by checking threadio->stop before calling internal vb2 queuing operations. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Cc: <stable@vger.kernel.org> # for v3.16 and up Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
1 parent 42d74e4
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs4 | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efivarfs | ||
| efs | ||
| exofs | ||
| exportfs | ||
| ext2 | ||
| ext3 | ||
| ext4 | ||
| f2fs | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hppfs | ||
| hugetlbfs | ||
| isofs | ||
| jbd | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| kernfs | ||
| lockd | ||
| logfs | ||
| minix | ||
| ncpfs | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| overlayfs | ||
| proc | ||
| pstore | ||
| qnx4 | ||
| qnx6 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| ubifs | ||
| udf | ||
| ufs | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 6.0 KB |
| Kconfig.binfmt | -rw-r--r-- | 7.2 KB |
| Makefile | -rw-r--r-- | 4.1 KB |
| aio.c | -rw-r--r-- | 41.8 KB |
| anon_inodes.c | -rw-r--r-- | 4.9 KB |
| attr.c | -rw-r--r-- | 7.9 KB |
| bad_inode.c | -rw-r--r-- | 7.8 KB |
| binfmt_aout.c | -rw-r--r-- | 10.8 KB |
| binfmt_elf.c | -rw-r--r-- | 56.9 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 46.9 KB |
| binfmt_em86.c | -rw-r--r-- | 2.6 KB |
| binfmt_flat.c | -rw-r--r-- | 26.4 KB |
| binfmt_misc.c | -rw-r--r-- | 15.3 KB |
| binfmt_script.c | -rw-r--r-- | 2.7 KB |
| binfmt_som.c | -rw-r--r-- | 7.1 KB |
| block_dev.c | -rw-r--r-- | 44.0 KB |
| buffer.c | -rw-r--r-- | 88.8 KB |
| char_dev.c | -rw-r--r-- | 14.1 KB |
| compat.c | -rw-r--r-- | 37.0 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.7 KB |
| compat_ioctl.c | -rw-r--r-- | 45.4 KB |
| coredump.c | -rw-r--r-- | 18.1 KB |
| dcache.c | -rw-r--r-- | 87.9 KB |
| dcookies.c | -rw-r--r-- | 6.9 KB |
| direct-io.c | -rw-r--r-- | 37.6 KB |
| drop_caches.c | -rw-r--r-- | 1.8 KB |
| eventfd.c | -rw-r--r-- | 11.3 KB |
| eventpoll.c | -rw-r--r-- | 59.0 KB |
| exec.c | -rw-r--r-- | 37.4 KB |
| fcntl.c | -rw-r--r-- | 16.6 KB |
| fhandle.c | -rw-r--r-- | 6.5 KB |
| file.c | -rw-r--r-- | 21.5 KB |
| file_table.c | -rw-r--r-- | 8.4 KB |
| filesystems.c | -rw-r--r-- | 6.4 KB |
| fs-writeback.c | -rw-r--r-- | 39.6 KB |
| fs_pin.c | -rw-r--r-- | 1.5 KB |
| fs_struct.c | -rw-r--r-- | 3.3 KB |
| inode.c | -rw-r--r-- | 50.0 KB |
| internal.h | -rw-r--r-- | 3.5 KB |
| ioctl.c | -rw-r--r-- | 15.5 KB |
| libfs.c | -rw-r--r-- | 27.9 KB |
| locks.c | -rw-r--r-- | 67.8 KB |
| mbcache.c | -rw-r--r-- | 24.1 KB |
| mount.h | -rw-r--r-- | 3.4 KB |
| mpage.c | -rw-r--r-- | 19.9 KB |
| namei.c | -rw-r--r-- | 111.8 KB |
| namespace.c | -rw-r--r-- | 77.9 KB |
| no-block.c | -rw-r--r-- | 688 bytes |
| open.c | -rw-r--r-- | 26.4 KB |
| pipe.c | -rw-r--r-- | 25.0 KB |
| pnode.c | -rw-r--r-- | 10.1 KB |
| pnode.h | -rw-r--r-- | 1.7 KB |
| posix_acl.c | -rw-r--r-- | 19.9 KB |
| proc_namespace.c | -rw-r--r-- | 7.4 KB |
| read_write.c | -rw-r--r-- | 30.2 KB |
| readdir.c | -rw-r--r-- | 6.9 KB |
| select.c | -rw-r--r-- | 25.4 KB |
| seq_file.c | -rw-r--r-- | 21.9 KB |
| signalfd.c | -rw-r--r-- | 9.1 KB |
| splice.c | -rw-r--r-- | 46.1 KB |
| stack.c | -rw-r--r-- | 2.5 KB |
| stat.c | -rw-r--r-- | 12.0 KB |
| statfs.c | -rw-r--r-- | 5.3 KB |
| super.c | -rw-r--r-- | 34.9 KB |
| sync.c | -rw-r--r-- | 9.5 KB |
| timerfd.c | -rw-r--r-- | 13.0 KB |
| utimes.c | -rw-r--r-- | 5.9 KB |
| xattr.c | -rw-r--r-- | 22.9 KB |
Computing file changes ...
