Revision 6e2a4505dba0cae8faa701426185dfb7b49f537c authored by Alex Elder on 27 March 2013, 14:16:30 UTC, committed by Sage Weil on 29 March 2013, 18:32:07 UTC
A result of ENOENT from a read request for an object that's part of an rbd image indicates that there is a hole in that portion of the image. Similarly, a short read for such an object indicates that the remainder of the read should be interpreted a full read with zeros filling out the end of the request. This behavior is not correct for objects that are not backing rbd image data. Currently rbd_img_obj_request_callback() assumes it should be done for all objects. Change rbd_img_obj_request_callback() so it only does this zeroing for image objects. Encapsulate that special handling in its own function. Add an assertion that the image object request is a bio request, since we assume that (and we currently don't support any other types). This resolves a problem identified here: http://tracker.ceph.com/issues/4559 The regression was introduced by bf0d5f503dc11d6314c0503591d258d60ee9c944. Reported-by: Dan van der Ster <dan@vanderster.com> Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-off-by: Sage Weil <sage@inktank.com>
1 parent d6c0dd6
File | Mode | Size |
---|---|---|
Makefile | -rw-r--r-- | 394 bytes |
compat.c | -rw-r--r-- | 18.5 KB |
compat_mq.c | -rw-r--r-- | 4.1 KB |
ipc_sysctl.c | -rw-r--r-- | 6.9 KB |
ipcns_notifier.c | -rw-r--r-- | 2.2 KB |
mq_sysctl.c | -rw-r--r-- | 2.7 KB |
mqueue.c | -rw-r--r-- | 35.1 KB |
msg.c | -rw-r--r-- | 22.7 KB |
msgutil.c | -rw-r--r-- | 3.6 KB |
namespace.c | -rw-r--r-- | 4.6 KB |
sem.c | -rw-r--r-- | 42.3 KB |
shm.c | -rw-r--r-- | 29.9 KB |
syscall.c | -rw-r--r-- | 2.3 KB |
util.c | -rw-r--r-- | 23.3 KB |
util.h | -rw-r--r-- | 5.4 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...