Revision 7004e454899490f16e0a2e5fd2e26f10d01ef091 authored by Andrew Kryczka on 26 April 2018, 21:33:02 UTC, committed by Facebook Github Bot on 26 April 2018, 21:43:11 UTC
Summary: 7a6353bd1c516fe3f7118248c77035697c5ac247 prevents empty filter blocks from being written for SST files containing range deletions only. However the assertion this PR removes is still a problem as we could be reading from a DB generated by a RocksDB build without the 7a6353bd1c516fe3f7118248c77035697c5ac247 patch. So remove the assertion. We already don't do this check when `cache_index_and_filter_blocks=false`, so it should be safe. Closes https://github.com/facebook/rocksdb/pull/3773 Differential Revision: D7769964 Pulled By: ajkr fbshipit-source-id: 7285762446f2cd2ccf16efd7a988a106fbb0d8d3
1 parent 63c965c
| File | Mode | Size |
|---|---|---|
| cf_options.cc | -rw-r--r-- | 7.6 KB |
| cf_options.h | -rw-r--r-- | 7.9 KB |
| db_options.cc | -rw-r--r-- | 13.5 KB |
| db_options.h | -rw-r--r-- | 3.1 KB |
| options.cc | -rw-r--r-- | 22.8 KB |
| options_helper.cc | -rw-r--r-- | 82.0 KB |
| options_helper.h | -rw-r--r-- | 8.2 KB |
| options_parser.cc | -rw-r--r-- | 29.9 KB |
| options_parser.h | -rw-r--r-- | 5.1 KB |
| options_sanity_check.cc | -rw-r--r-- | 1.1 KB |
| options_sanity_check.h | -rw-r--r-- | 1.7 KB |
| options_settable_test.cc | -rw-r--r-- | 20.5 KB |
| options_test.cc | -rw-r--r-- | 73.5 KB |
Computing file changes ...
