Revision 7168d16103cb9e48bde9f435c21b0f02186f5d7f authored by Levi Tamasi on 20 December 2019, 02:03:24 UTC, committed by Levi Tamasi on 20 December 2019, 02:29:39 UTC
Summary:
BlobDB currently only supports using the default column family. The earlier
code enforces this by comparing the `ColumnFamilyHandle` passed to the
`Get`/`Put`/etc. call with the handle returned by `DefaultColumnFamily`
(which, at the end of the day, comes from `DBImpl::default_cf_handle_`).
Since other `ColumnFamilyHandle`s can also point to the default column
family, this can reject legitimate requests as well. (As an example,
with the earlier code, the handle returned by `BlobDB::Open` cannot
actually be used in API calls.) The patch fixes this by comparing only
the IDs of the column family handles instead of the pointers themselves.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6226

Test Plan: `make check`

Differential Revision: D19187461

Pulled By: ltamasi

fbshipit-source-id: 54ce2e12ebb1f07e6d1e70e3b1e0213dfa94bda2
1 parent d848059
History
File Mode Size
_data
_docs
_includes
_layouts
_posts
_sass
_top-level
blog
css
doc-type-examples
docs
static
.gitignore -rw-r--r-- 56 bytes
CNAME -rw-r--r-- 11 bytes
CONTRIBUTING.md -rw-r--r-- 4.7 KB
Gemfile -rw-r--r-- 59 bytes
Gemfile.lock -rw-r--r-- 3.5 KB
LICENSE-DOCUMENTATION -rw-r--r-- 17.7 KB
README.md -rw-r--r-- 3.1 KB
TEMPLATE-INFORMATION.md -rw-r--r-- 2.5 KB
_config.yml -rw-r--r-- 2.8 KB
feed.xml -rw-r--r-- 1.2 KB
index.md -rw-r--r-- 174 bytes

README.md

back to top