Skip to main content

Browse the archive

Revision 7168d16103cb9e48bde9f435c21b0f02186f5d7f authored by Levi Tamasi on 20 December 2019, 02:03:24 UTC, committed by Levi Tamasi on 20 December 2019, 02:29:39 UTC 
BlobDB: only compare CF IDs when checking whether an API call is for the default CF (#6226)
 
Summary:
BlobDB currently only supports using the default column family. The earlier
code enforces this by comparing the `ColumnFamilyHandle` passed to the
`Get`/`Put`/etc. call with the handle returned by `DefaultColumnFamily`
(which, at the end of the day, comes from `DBImpl::default_cf_handle_`).
Since other `ColumnFamilyHandle`s can also point to the default column
family, this can reject legitimate requests as well. (As an example,
with the earlier code, the handle returned by `BlobDB::Open` cannot
actually be used in API calls.) The patch fixes this by comparing only
the IDs of the column family handles instead of the pointers themselves.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6226

Test Plan: `make check`

Differential Revision: D19187461

Pulled By: ltamasi

fbshipit-source-id: 54ce2e12ebb1f07e6d1e70e3b1e0213dfa94bda2
1 parent d848059
History
File Mode Size
2014-03-27-how-to-backup-rocksdb.markdown -rw-r--r-- 7.6 KB
2014-03-27-how-to-persist-in-memory-rocksdb-database.markdown -rw-r--r-- 3.4 KB
2014-04-02-the-1st-rocksdb-local-meetup-held-on-march-27-2014.markdown -rw-r--r-- 2.1 KB
2014-04-07-rocksdb-2-8-release.markdown -rw-r--r-- 1.6 KB
2014-04-21-indexing-sst-files-for-better-lookup-performance.markdown -rw-r--r-- 3.8 KB
2014-05-14-lock.markdown -rw-r--r-- 9.3 KB
2014-05-19-rocksdb-3-0-release.markdown -rw-r--r-- 662 bytes
2014-05-22-rocksdb-3-1-release.markdown -rw-r--r-- 577 bytes
2014-06-23-plaintable-a-new-file-format.markdown -rw-r--r-- 3.0 KB
2014-06-27-avoid-expensive-locks-in-get.markdown -rw-r--r-- 4.7 KB
2014-06-27-rocksdb-3-2-release.markdown -rw-r--r-- 1.0 KB
2014-07-29-rocksdb-3-3-release.markdown -rw-r--r-- 1.6 KB
2014-09-12-cuckoo.markdown -rw-r--r-- 4.4 KB
2014-09-12-new-bloom-filter-format.markdown -rw-r--r-- 3.1 KB
2014-09-15-rocksdb-3-5-release.markdown -rw-r--r-- 1.3 KB
2015-01-16-migrating-from-leveldb-to-rocksdb-2.markdown -rw-r--r-- 3.1 KB
2015-02-24-reading-rocksdb-options-from-a-file.markdown -rw-r--r-- 1.7 KB
2015-02-27-write-batch-with-index.markdown -rw-r--r-- 3.8 KB
2015-04-22-integrating-rocksdb-with-mongodb-2.markdown -rw-r--r-- 902 bytes
2015-06-12-rocksdb-in-osquery.markdown -rw-r--r-- 502 bytes
2015-07-15-rocksdb-2015-h2-roadmap.markdown -rw-r--r-- 3.0 KB
2015-07-17-spatial-indexing-in-rocksdb.markdown -rw-r--r-- 4.8 KB
2015-07-22-rocksdb-is-now-available-in-windows-platform.markdown -rw-r--r-- 1.0 KB
2015-07-23-dynamic-level.markdown -rw-r--r-- 4.3 KB
2015-10-27-getthreadlist.markdown -rw-r--r-- 5.0 KB
2015-11-10-use-checkpoints-for-efficient-snapshots.markdown -rw-r--r-- 2.0 KB
2015-11-16-analysis-file-read-latency-by-level.markdown -rw-r--r-- 12.1 KB
2016-01-29-compaction_pri.markdown -rw-r--r-- 6.9 KB
2016-02-24-rocksdb-4-2-release.markdown -rw-r--r-- 1.3 KB
2016-02-25-rocksdb-ama.markdown -rw-r--r-- 731 bytes
2016-03-07-rocksdb-options-file.markdown -rw-r--r-- 1.2 KB
2016-04-26-rocksdb-4-5-1-released.markdown -rw-r--r-- 2.8 KB
2016-07-26-rocksdb-4-8-released.markdown -rw-r--r-- 3.5 KB
2016-09-28-rocksdb-4-11-2-released.markdown -rw-r--r-- 2.2 KB
2017-01-06-rocksdb-5-0-1-released.markdown -rw-r--r-- 2.0 KB
2017-02-07-rocksdb-5-1-2-released.markdown -rw-r--r-- 662 bytes
2017-02-17-bulkoad-ingest-sst-file.markdown -rw-r--r-- 2.3 KB
2017-03-02-rocksdb-5-2-1-released.markdown -rw-r--r-- 1.3 KB
2017-05-12-partitioned-index-filter.markdown -rw-r--r-- 3.6 KB
2017-05-14-core-local-stats.markdown -rw-r--r-- 5.4 KB
2017-05-26-rocksdb-5-4-5-released.markdown -rw-r--r-- 2.4 KB
2017-06-26-17-level-based-changes.markdown -rw-r--r-- 5.6 KB
2017-06-29-rocksdb-5-5-1-released.markdown -rw-r--r-- 1.0 KB
2017-07-25-rocksdb-5-6-1-released.markdown -rw-r--r-- 1.9 KB
2017-08-24-pinnableslice.markdown -rw-r--r-- 2.2 KB
2017-08-25-flushwal.markdown -rw-r--r-- 2.9 KB
2017-09-28-rocksdb-5-8-released.markdown -rw-r--r-- 1.9 KB
2017-12-18-17-auto-tuned-rate-limiter.markdown -rw-r--r-- 2.3 KB
2017-12-19-write-prepared-txn.markdown -rw-r--r-- 5.6 KB
2018-02-05-rocksdb-5-10-2-released.markdown -rw-r--r-- 1.5 KB
2018-08-01-rocksdb-tuning-advisor.markdown -rw-r--r-- 2.8 KB
2018-08-23-data-block-hash-index.markdown -rw-r--r-- 9.0 KB
2018-11-21-delete-range.markdown -rw-r--r-- 15.5 KB
2019-03-08-format-version-4.markdown -rw-r--r-- 2.7 KB
2019-08-15-unordered-write.markdown -rw-r--r-- 2.7 KB
back to top