Revision 7168d16103cb9e48bde9f435c21b0f02186f5d7f authored by Levi Tamasi on 20 December 2019, 02:03:24 UTC, committed by Levi Tamasi on 20 December 2019, 02:29:39 UTC
Summary: BlobDB currently only supports using the default column family. The earlier code enforces this by comparing the `ColumnFamilyHandle` passed to the `Get`/`Put`/etc. call with the handle returned by `DefaultColumnFamily` (which, at the end of the day, comes from `DBImpl::default_cf_handle_`). Since other `ColumnFamilyHandle`s can also point to the default column family, this can reject legitimate requests as well. (As an example, with the earlier code, the handle returned by `BlobDB::Open` cannot actually be used in API calls.) The patch fixes this by comparing only the IDs of the column family handles instead of the pointers themselves. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6226 Test Plan: `make check` Differential Revision: D19187461 Pulled By: ltamasi fbshipit-source-id: 54ce2e12ebb1f07e6d1e70e3b1e0213dfa94bda2
1 parent d848059
| File | Mode | Size |
|---|---|---|
| .gitignore | -rw-r--r-- | 200 bytes |
| Makefile | -rw-r--r-- | 2.5 KB |
| README.md | -rw-r--r-- | 120 bytes |
| c_simple_example.c | -rw-r--r-- | 2.6 KB |
| column_families_example.cc | -rw-r--r-- | 1.9 KB |
| compact_files_example.cc | -rw-r--r-- | 5.7 KB |
| compaction_filter_example.cc | -rw-r--r-- | 2.9 KB |
| multi_processes_example.cc | -rw-r--r-- | 11.6 KB |
| optimistic_transaction_example.cc | -rw-r--r-- | 4.1 KB |
| options_file_example.cc | -rw-r--r-- | 4.0 KB |
| rocksdb_option_file_example.ini | -rw-r--r-- | 4.6 KB |
| simple_example.cc | -rw-r--r-- | 2.4 KB |
| transaction_example.cc | -rw-r--r-- | 4.6 KB |
Computing file changes ...
