Revision 7168d16103cb9e48bde9f435c21b0f02186f5d7f authored by Levi Tamasi on 20 December 2019, 02:03:24 UTC, committed by Levi Tamasi on 20 December 2019, 02:29:39 UTC
Summary: BlobDB currently only supports using the default column family. The earlier code enforces this by comparing the `ColumnFamilyHandle` passed to the `Get`/`Put`/etc. call with the handle returned by `DefaultColumnFamily` (which, at the end of the day, comes from `DBImpl::default_cf_handle_`). Since other `ColumnFamilyHandle`s can also point to the default column family, this can reject legitimate requests as well. (As an example, with the earlier code, the handle returned by `BlobDB::Open` cannot actually be used in API calls.) The patch fixes this by comparing only the IDs of the column family handles instead of the pointers themselves. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6226 Test Plan: `make check` Differential Revision: D19187461 Pulled By: ltamasi fbshipit-source-id: 54ce2e12ebb1f07e6d1e70e3b1e0213dfa94bda2
1 parent d848059
File | Mode | Size |
---|---|---|
adaptive | ||
block_based | ||
cuckoo | ||
plain | ||
block_fetcher.cc | -rw-r--r-- | 9.7 KB |
block_fetcher.h | -rw-r--r-- | 4.4 KB |
cleanable_test.cc | -rw-r--r-- | 6.4 KB |
format.cc | -rw-r--r-- | 16.6 KB |
format.h | -rw-r--r-- | 12.6 KB |
get_context.cc | -rw-r--r-- | 13.1 KB |
get_context.h | -rw-r--r-- | 7.5 KB |
internal_iterator.h | -rw-r--r-- | 6.6 KB |
iter_heap.h | -rw-r--r-- | 1.2 KB |
iterator.cc | -rw-r--r-- | 6.7 KB |
iterator_wrapper.h | -rw-r--r-- | 3.6 KB |
merger_test.cc | -rw-r--r-- | 4.5 KB |
merging_iterator.cc | -rw-r--r-- | 13.6 KB |
merging_iterator.h | -rw-r--r-- | 2.1 KB |
meta_blocks.cc | -rw-r--r-- | 19.8 KB |
meta_blocks.h | -rw-r--r-- | 6.2 KB |
mock_table.cc | -rw-r--r-- | 4.5 KB |
mock_table.h | -rw-r--r-- | 6.1 KB |
multiget_context.h | -rw-r--r-- | 8.3 KB |
persistent_cache_helper.cc | -rw-r--r-- | 4.2 KB |
persistent_cache_helper.h | -rw-r--r-- | 1.5 KB |
persistent_cache_options.h | -rw-r--r-- | 1.0 KB |
scoped_arena_iterator.h | -rw-r--r-- | 1.6 KB |
sst_file_reader.cc | -rw-r--r-- | 3.0 KB |
sst_file_reader_test.cc | -rw-r--r-- | 5.0 KB |
sst_file_writer.cc | -rw-r--r-- | 10.9 KB |
sst_file_writer_collectors.h | -rw-r--r-- | 3.1 KB |
table_builder.h | -rw-r--r-- | 6.6 KB |
table_properties.cc | -rw-r--r-- | 10.4 KB |
table_properties_internal.h | -rw-r--r-- | 1.0 KB |
table_reader.h | -rw-r--r-- | 5.8 KB |
table_reader_bench.cc | -rw-r--r-- | 12.6 KB |
table_reader_caller.h | -rw-r--r-- | 1.5 KB |
table_test.cc | -rw-r--r-- | 159.2 KB |
two_level_iterator.cc | -rw-r--r-- | 6.3 KB |
two_level_iterator.h | -rw-r--r-- | 1.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...