Revision 7168d16103cb9e48bde9f435c21b0f02186f5d7f authored by Levi Tamasi on 20 December 2019, 02:03:24 UTC, committed by Levi Tamasi on 20 December 2019, 02:29:39 UTC
Summary: BlobDB currently only supports using the default column family. The earlier code enforces this by comparing the `ColumnFamilyHandle` passed to the `Get`/`Put`/etc. call with the handle returned by `DefaultColumnFamily` (which, at the end of the day, comes from `DBImpl::default_cf_handle_`). Since other `ColumnFamilyHandle`s can also point to the default column family, this can reject legitimate requests as well. (As an example, with the earlier code, the handle returned by `BlobDB::Open` cannot actually be used in API calls.) The patch fixes this by comparing only the IDs of the column family handles instead of the pointers themselves. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6226 Test Plan: `make check` Differential Revision: D19187461 Pulled By: ltamasi fbshipit-source-id: 54ce2e12ebb1f07e6d1e70e3b1e0213dfa94bda2
1 parent d848059
| File | Mode | Size |
|---|---|---|
| fault_injection_test_env.cc | -rw-r--r-- | 12.8 KB |
| fault_injection_test_env.h | -rw-r--r-- | 7.1 KB |
| mock_time_env.h | -rw-r--r-- | 1.2 KB |
| sync_point.cc | -rw-r--r-- | 1.6 KB |
| sync_point.h | -rw-r--r-- | 4.9 KB |
| sync_point_impl.cc | -rw-r--r-- | 3.5 KB |
| sync_point_impl.h | -rw-r--r-- | 2.4 KB |
| testharness.cc | -rw-r--r-- | 1.6 KB |
| testharness.h | -rw-r--r-- | 1.5 KB |
| testutil.cc | -rw-r--r-- | 15.0 KB |
| testutil.h | -rw-r--r-- | 23.8 KB |
| transaction_test_util.cc | -rw-r--r-- | 13.1 KB |
| transaction_test_util.h | -rw-r--r-- | 4.8 KB |
Computing file changes ...
