Revision 75133b1b6b6d22d6bd2c156c062ec44f6f36c189 authored by Yi Wu on 26 March 2019, 17:15:43 UTC, committed by Facebook Github Bot on 26 March 2019, 17:25:18 UTC
Summary: Since `SstFileReader` don't know largest seqno of a file, it will fail this check when it open a file with global seqno: https://github.com/facebook/rocksdb/blob/ca89ac2ba997dfa0e135bd75d4ccf6f5774a7eff/table/block_based_table_reader.cc#L730 Changes: * Pass largest_seqno=kMaxSequenceNumber from `SstFileReader` and allow it to bypass the above check. * `BlockBasedTable::VerifyChecksum` also double check if checksum will match when excluding global seqno (this is to make the new test in sst_table_reader_test pass). Pull Request resolved: https://github.com/facebook/rocksdb/pull/5097 Differential Revision: D14607434 Pulled By: riversand963 fbshipit-source-id: 9008599227c5fccbf9b73fee46b3bf4a1523f023
1 parent 7ca9eb7
| File | Mode | Size |
|---|---|---|
| backupable | ||
| blob_db | ||
| cassandra | ||
| checkpoint | ||
| compaction_filters | ||
| convenience | ||
| leveldb_options | ||
| memory | ||
| merge_operators | ||
| option_change_migration | ||
| options | ||
| persistent_cache | ||
| simulator_cache | ||
| table_properties_collectors | ||
| trace | ||
| transactions | ||
| ttl | ||
| write_batch_with_index | ||
| debug.cc | -rw-r--r-- | 1.9 KB |
| env_librados.cc | -rw-r--r-- | 36.1 KB |
| env_librados.md | -rw-r--r-- | 4.6 KB |
| env_librados_test.cc | -rw-r--r-- | 34.5 KB |
| env_mirror.cc | -rw-r--r-- | 7.8 KB |
| env_mirror_test.cc | -rw-r--r-- | 7.0 KB |
| env_timed.cc | -rw-r--r-- | 5.1 KB |
| env_timed_test.cc | -rw-r--r-- | 1.2 KB |
| merge_operators.h | -rw-r--r-- | 1.8 KB |
| object_registry_test.cc | -rw-r--r-- | 2.1 KB |
| util_merge_operators_test.cc | -rw-r--r-- | 3.2 KB |
Computing file changes ...
