Revision 75133b1b6b6d22d6bd2c156c062ec44f6f36c189 authored by Yi Wu on 26 March 2019, 17:15:43 UTC, committed by Facebook Github Bot on 26 March 2019, 17:25:18 UTC
Summary: Since `SstFileReader` don't know largest seqno of a file, it will fail this check when it open a file with global seqno: https://github.com/facebook/rocksdb/blob/ca89ac2ba997dfa0e135bd75d4ccf6f5774a7eff/table/block_based_table_reader.cc#L730 Changes: * Pass largest_seqno=kMaxSequenceNumber from `SstFileReader` and allow it to bypass the above check. * `BlockBasedTable::VerifyChecksum` also double check if checksum will match when excluding global seqno (this is to make the new test in sst_table_reader_test pass). Pull Request resolved: https://github.com/facebook/rocksdb/pull/5097 Differential Revision: D14607434 Pulled By: riversand963 fbshipit-source-id: 9008599227c5fccbf9b73fee46b3bf4a1523f023
1 parent 7ca9eb7
| File | Mode | Size |
|---|---|---|
| blob_compaction_filter.cc | -rw-r--r-- | 4.0 KB |
| blob_compaction_filter.h | -rw-r--r-- | 1.4 KB |
| blob_db.cc | -rw-r--r-- | 3.5 KB |
| blob_db.h | -rw-r--r-- | 8.4 KB |
| blob_db_impl.cc | -rw-r--r-- | 64.3 KB |
| blob_db_impl.h | -rw-r--r-- | 14.1 KB |
| blob_db_impl_filesnapshot.cc | -rw-r--r-- | 3.4 KB |
| blob_db_iterator.h | -rw-r--r-- | 3.6 KB |
| blob_db_listener.h | -rw-r--r-- | 1.2 KB |
| blob_db_test.cc | -rw-r--r-- | 56.7 KB |
| blob_dump_tool.cc | -rw-r--r-- | 9.0 KB |
| blob_dump_tool.h | -rw-r--r-- | 1.7 KB |
| blob_file.cc | -rw-r--r-- | 9.8 KB |
| blob_file.h | -rw-r--r-- | 5.9 KB |
| blob_index.h | -rw-r--r-- | 5.0 KB |
| blob_log_format.cc | -rw-r--r-- | 5.1 KB |
| blob_log_format.h | -rw-r--r-- | 4.1 KB |
| blob_log_reader.cc | -rw-r--r-- | 2.9 KB |
| blob_log_reader.h | -rw-r--r-- | 2.3 KB |
| blob_log_writer.cc | -rw-r--r-- | 4.0 KB |
| blob_log_writer.h | -rw-r--r-- | 2.7 KB |
Computing file changes ...
