https://github.com/torvalds/linux
Revision 771b894f2f3dfedc2ba5561731fffa0e39b1bbb6 authored by Sargun Dhillon on 30 December 2019, 20:35:03 UTC, committed by Kees Cook on 02 January 2020, 21:03:39 UTC
The sizes by which seccomp_notif and seccomp_notif_resp are allocated are
based on the SECCOMP_GET_NOTIF_SIZES ioctl. This allows for graceful
extension of these datastructures. If userspace zeroes out the
datastructure based on its version, and it is lagging behind the kernel's
version, it will end up sending trailing garbage. On the other hand,
if it is ahead of the kernel version, it will write extra zero space,
and potentially cause corruption.

Signed-off-by: Sargun Dhillon <sargun@sargun.me>
Suggested-by: Tycho Andersen <tycho@tycho.ws>
Link: https://lore.kernel.org/r/20191230203503.4925-1-sargun@sargun.me
Fixes: fec7b6690541 ("samples: add an example of seccomp user trap")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
1 parent fd69884
History
Tip revision: 771b894f2f3dfedc2ba5561731fffa0e39b1bbb6 authored by Sargun Dhillon on 30 December 2019, 20:35:03 UTC
samples/seccomp: Zero out members based on seccomp_notif_sizes
Tip revision: 771b894
File Mode Size
include
.gitignore -rw-r--r-- 143 bytes
Kconfig -rw-r--r-- 7.9 KB
Makefile -rw-r--r-- 2.2 KB
gen_init_cpio.c -rw-r--r-- 12.8 KB
gen_initramfs_list.sh -rwxr-xr-x 8.0 KB
initramfs_data.S -rw-r--r-- 1.3 KB

back to top