Revision 774a1221e862b343388347bac9b318767336b20b authored by Tejun Heo on 16 January 2013, 02:52:51 UTC, committed by Linus Torvalds on 16 January 2013, 17:05:33 UTC
If the default iosched is built as module, the kernel may deadlock
while trying to load the iosched module on device probe if the probing
was running off async.  This is because async_synchronize_full() at
the end of module init ends up waiting for the async job which
initiated the module loading.

 async A				modprobe

 1. finds a device
 2. registers the block device
 3. request_module(default iosched)
					4. modprobe in userland
					5. load and init module
					6. async_synchronize_full()

Async A waits for modprobe to finish in request_module() and modprobe
waits for async A to finish in async_synchronize_full().

Because there's no easy to track dependency once control goes out to
userland, implementing properly nested flushing is difficult.  For
now, make module init perform async_synchronize_full() iff module init
has queued async jobs as suggested by Linus.

This avoids the described deadlock because iosched module doesn't use
async and thus wouldn't invoke async_synchronize_full().  This is
hacky and incomplete.  It will deadlock if async module loading nests;
however, this works around the known problem case and seems to be the
best of bad options.

For more details, please refer to the following thread.

  http://thread.gmane.org/gmane.linux.kernel/1420814

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Alex Riesen <raa.lkml@gmail.com>
Tested-by: Ming Lei <ming.lei@canonical.com>
Tested-by: Alex Riesen <raa.lkml@gmail.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 406089d
History
File Mode Size
9p
adfs
affs
afs
autofs4
befs
bfs
btrfs
cachefiles
ceph
cifs
coda
configfs
cramfs
debugfs
devpts
dlm
ecryptfs
efs
exofs
exportfs
ext2
ext3
ext4
f2fs
fat
freevxfs
fscache
fuse
gfs2
hfs
hfsplus
hostfs
hpfs
hppfs
hugetlbfs
isofs
jbd
jbd2
jffs2
jfs
lockd
logfs
minix
ncpfs
nfs
nfs_common
nfsd
nilfs2
nls
notify
ntfs
ocfs2
omfs
openpromfs
proc
pstore
qnx4
qnx6
quota
ramfs
reiserfs
romfs
squashfs
sysfs
sysv
ubifs
udf
ufs
xfs
Kconfig -rw-r--r-- 6.2 KB
Kconfig.binfmt -rw-r--r-- 6.7 KB
Makefile -rw-r--r-- 4.1 KB
aio.c -rw-r--r-- 45.7 KB
anon_inodes.c -rw-r--r-- 6.4 KB
attr.c -rw-r--r-- 7.0 KB
bad_inode.c -rw-r--r-- 7.7 KB
binfmt_aout.c -rw-r--r-- 11.7 KB
binfmt_elf.c -rw-r--r-- 57.8 KB
binfmt_elf_fdpic.c -rw-r--r-- 48.5 KB
binfmt_em86.c -rw-r--r-- 2.7 KB
binfmt_flat.c -rw-r--r-- 26.7 KB
binfmt_misc.c -rw-r--r-- 15.0 KB
binfmt_script.c -rw-r--r-- 2.7 KB
binfmt_som.c -rw-r--r-- 7.1 KB
bio-integrity.c -rw-r--r-- 20.5 KB
bio.c -rw-r--r-- 40.2 KB
block_dev.c -rw-r--r-- 42.0 KB
buffer.c -rw-r--r-- 87.0 KB
char_dev.c -rw-r--r-- 14.0 KB
compat.c -rw-r--r-- 44.7 KB
compat_binfmt_elf.c -rw-r--r-- 3.6 KB
compat_ioctl.c -rw-r--r-- 45.5 KB
coredump.c -rw-r--r-- 16.5 KB
coredump.h -rw-r--r-- 106 bytes
dcache.c -rw-r--r-- 79.5 KB
dcookies.c -rw-r--r-- 6.8 KB
direct-io.c -rw-r--r-- 37.4 KB
drop_caches.c -rw-r--r-- 1.5 KB
eventfd.c -rw-r--r-- 11.3 KB
eventpoll.c -rw-r--r-- 54.7 KB
exec.c -rw-r--r-- 39.1 KB
fcntl.c -rw-r--r-- 16.3 KB
fhandle.c -rw-r--r-- 6.5 KB
fifo.c -rw-r--r-- 3.2 KB
file.c -rw-r--r-- 23.4 KB
file_table.c -rw-r--r-- 12.2 KB
filesystems.c -rw-r--r-- 6.4 KB
fs-writeback.c -rw-r--r-- 39.4 KB
fs_struct.c -rw-r--r-- 3.2 KB
generic_acl.c -rw-r--r-- 3.9 KB
inode.c -rw-r--r-- 48.7 KB
internal.h -rw-r--r-- 3.0 KB
ioctl.c -rw-r--r-- 15.6 KB
ioprio.c -rw-r--r-- 5.0 KB
libfs.c -rw-r--r-- 25.7 KB
locks.c -rw-r--r-- 58.7 KB
mbcache.c -rw-r--r-- 16.4 KB
mount.h -rw-r--r-- 2.3 KB
mpage.c -rw-r--r-- 20.0 KB
namei.c -rw-r--r-- 100.2 KB
namespace.c -rw-r--r-- 68.2 KB
no-block.c -rw-r--r-- 688 bytes
open.c -rw-r--r-- 25.2 KB
pipe.c -rw-r--r-- 28.9 KB
pnode.c -rw-r--r-- 8.8 KB
pnode.h -rw-r--r-- 1.5 KB
posix_acl.c -rw-r--r-- 9.2 KB
proc_namespace.c -rw-r--r-- 7.5 KB
read_write.c -rw-r--r-- 21.7 KB
read_write.h -rw-r--r-- 632 bytes
readdir.c -rw-r--r-- 6.8 KB
select.c -rw-r--r-- 24.0 KB
seq_file.c -rw-r--r-- 19.6 KB
signalfd.c -rw-r--r-- 8.3 KB
splice.c -rw-r--r-- 46.3 KB
stack.c -rw-r--r-- 2.5 KB
stat.c -rw-r--r-- 11.3 KB
statfs.c -rw-r--r-- 5.3 KB
super.c -rw-r--r-- 34.6 KB
sync.c -rw-r--r-- 10.6 KB
timerfd.c -rw-r--r-- 8.5 KB
utimes.c -rw-r--r-- 5.7 KB
xattr.c -rw-r--r-- 23.5 KB
xattr_acl.c -rw-r--r-- 4.3 KB

back to top