Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 77dc2db6d1d2703ee4e83d4b3dbecf4e06a910e6 authored by Mark Assad on 05 October 2006, 02:25:05 UTC, committed by Linus Torvalds on 05 October 2006, 02:44:36 UTC 
[PATCH] itmtouch: fix inverted flag to indicate touch location correctly, correct white space
 
There is a bug in the current version of the itmtouch USB touchscreen
driver.  The if statment that checks if pressure is being applied to the
touch screen is now missing a ! (not), so events are no longer being
reported correctly.

The original source code for this line was as follows:

	#define UCP(x) ((unsigned char*)(x))
	#define UCOM(x,y,z) ((UCP((x)->transfer_buffer)[y]) & (z))

	...
	if (!UCOM(urb, 7, 0x20)) {

And was cleaned to:

	unsigned char *data = urb->transfer_buffer;
	....
	 if (data[7] & 0x20) {

(note the lack of '!')

This has been tested on an LG L1510BF and an LG1510SF touch screen.

Signed-off-by: Mark Assad <massad@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent 4b84471
History
Tip revision: 77dc2db6d1d2703ee4e83d4b3dbecf4e06a910e6 authored by Mark Assad on 05 October 2006, 02:25:05 UTC
[PATCH] itmtouch: fix inverted flag to indicate touch location correctly, correct white space
Tip revision: 77dc2db
File Mode Size
Documentation
arch
block
crypto
drivers
fs
include
init
ipc
kernel
lib
mm
net
scripts
security
sound
usr
.gitignore -rw-r--r-- 542 bytes
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 88.2 KB
Kbuild -rw-r--r-- 1.2 KB
MAINTAINERS -rw-r--r-- 73.0 KB
Makefile -rw-r--r-- 48.8 KB
README -rw-r--r-- 16.2 KB
REPORTING-BUGS -rw-r--r-- 3.0 KB

README

back to top